Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on the version drop-down menu in the handbook returns to the introduction #235

Closed
cmnrd opened this issue Feb 14, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@cmnrd
Copy link
Contributor

cmnrd commented Feb 14, 2024

I intuitively click on the little down arrow next to the version selection drop-down menu. Apparently, it is sufficient to hover over the menu and then select a version. However, my brain seems to be hard-coded to clicking on drop-downs. This in itself is not a problem, but clicking on the drop-down menu actually navigates back to the introduction page, which breaks my flow. Is there a way to avoid navigating to another page when clicking on the menu?

@cmnrd cmnrd added the bug Something isn't working label Feb 14, 2024
@axmmisaka
Copy link
Collaborator

I'll look for configs, if one does not exist I'll try to fix it and file a PR for docusaurus repo

@axmmisaka
Copy link
Collaborator

I do not think I could reproduce the problem, unless you click version number in a non-document page. Do you think it would be better if it does nothing or do not appear when not on docs page?

@cmnrd
Copy link
Contributor Author

cmnrd commented Jun 3, 2024

I only noticed your response now... I think it would be best to do nothing when clicking on the current version (or the arrow next to it).

What do you mean by 'non-document' page? For me, it quite reliably jumps to the introduction page of the handbook when I am clicking on the version in any handbook page that is not the introduction page.

@axmmisaka
Copy link
Collaborator

2024-06-05.21-46-08.mp4

This is the behaviour on my end - can you check if it's the same on your end?

@cmnrd
Copy link
Contributor Author

cmnrd commented Jun 7, 2024

I think there is still a misunderstanding about the issue. The version dropdown menu works fine, and if I select a version, it stays on the same page. However, my issue is that I am used to clicking on the little arrow that appears next to the current version in order to open a dropdown menu. This is not needed in our case, as the menu opens when hovering over the current version. But if I don't think about it, my brain just lets me click on the current version to open the menu, and when I do that, it jumps back to the introduction page.

tl;dr When I click on the current version (not the dropdown), then it jumps to the introduction page, which is weird.

@axmmisaka
Copy link
Collaborator

I think there is still a misunderstanding about the issue. The version dropdown menu works fine, and if I select a version, it stays on the same page. However, my issue is that I am used to clicking on the little arrow that appears next to the current version in order to open a dropdown menu. This is not needed in our case, as the menu opens when hovering over the current version. But if I don't think about it, my brain just lets me click on the current version to open the menu, and when I do that, it jumps back to the introduction page.

tl;dr When I click on the current version (not the dropdown), then it jumps to the introduction page, which is weird.

I think there is still a misunderstanding about the issue. The version dropdown menu works fine, and if I select a version, it stays on the same page. However, my issue is that I am used to clicking on the little arrow that appears next to the current version in order to open a dropdown menu. This is not needed in our case, as the menu opens when hovering over the current version. But if I don't think about it, my brain just lets me click on the current version to open the menu, and when I do that, it jumps back to the introduction page.

tl;dr When I click on the current version (not the dropdown), then it jumps to the introduction page, which is weird.

Got it! This is counterintuitive and I think an upstream fix would be the most proper way of doing it (i.e. I'll PR in docusaurus repo)

@cmnrd
Copy link
Contributor Author

cmnrd commented Jun 9, 2024

Great. Thank you!

@axmmisaka
Copy link
Collaborator

This is closed after the great contributors of docusaurus wrote facebook/docusaurus#10288

@cmnrd
Copy link
Contributor Author

cmnrd commented Jul 12, 2024

Cool! How do we make this available in our builds, though?

@axmmisaka
Copy link
Collaborator

Cool! How do we make this available in our builds, though?

After upstream (docusaurus) releases a new version with this feature, we update our package.json - so it's just a matter of time, and we need to update eventually (I plan to have dependabot enabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants