Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric separator support #7817

Merged
merged 9 commits into from
Oct 30, 2019
Merged

Add numeric separator support #7817

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fea44de
Added support for numeric supporters by using babel
tharun208 Oct 13, 2019
e5e7768
Fixed linting issues
tharun208 Oct 13, 2019
7d5f89c
Added package for numeric separators in package.json
tharun208 Oct 13, 2019
4f41541
Added babel-syntax-jsx for node-10
tharun208 Oct 13, 2019
011ab19
Added numeric seperators support for all files
tharun208 Oct 17, 2019
22c56c4
alphabatically organized package.json
tharun208 Oct 17, 2019
7c7ca8c
Update package.json
ianschmitz Oct 17, 2019
23650bc
Be consistent with other plugins
ianschmitz Oct 17, 2019
81381b0
Merge branch 'master' into master
ianschmitz Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/babel-preset-react-app/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ module.exports = function(api, opts, env) {
require('@babel/plugin-proposal-decorators').default,
false,
],
// Adds Numeric Seperators for TypeScript files
isTypeScriptEnabled && [
ianschmitz marked this conversation as resolved.
Show resolved Hide resolved
require('@babel/plugin-proposal-numeric-separator'),
],
// class { handleClick = () => { } }
// Enable loose mode to use assignment instead of defineProperty
// See discussion in https://github.com/facebook/create-react-app/issues/4263
Expand Down
4 changes: 3 additions & 1 deletion packages/babel-preset-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
"@babel/runtime": "7.6.0",
"babel-plugin-dynamic-import-node": "2.3.0",
"babel-plugin-macros": "2.6.1",
"babel-plugin-transform-react-remove-prop-types": "0.4.24"
"babel-plugin-transform-react-remove-prop-types": "0.4.24",
"@babel/plugin-proposal-numeric-separator": "7.2.0",
ianschmitz marked this conversation as resolved.
Show resolved Hide resolved
"@babel/plugin-syntax-jsx": "7.2.0"
ianschmitz marked this conversation as resolved.
Show resolved Hide resolved
}
}
2 changes: 1 addition & 1 deletion packages/react-dev-utils/browsersHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function shouldSetBrowsers(isInteractive) {
}

function checkBrowsers(dir, isInteractive, retry = true) {
const current = browserslist.loadConfig({path: dir});
const current = browserslist.loadConfig({ path: dir });
if (current != null) {
return Promise.resolve(current);
}
Expand Down