Peer dependencies of eslint-config-react-app are outdated

[lukyth]

Is your proposal related to a problem?

Yes.

I got this warning when I install eslint-config-react-app

warning " > [email protected]" has incorrect peer dependency "[email protected]".
warning " > [email protected]" has incorrect peer dependency "[email protected]".

Turns out eslint-plugin-react-hooks is already at 2.1.1 now, and eslint-plugin-flowtype is at 4.3.0.

Describe the solution you'd like

I can update eslint-plugin-react-hooks and eslint-plugin-flowtype to the latest version if it's a good idea.

Describe alternatives you've considered

Make those two a dependencies instead of peer dependencies (#6129).

Additional context

None.

[chibicode]

Should be fine to upgrade eslint-plugin-react-hooks to v2. The breaking change is forbidding top level use*() calls: airbnb/javascript#2084 (comment)

Also should be fine to upgrade eslint-plugin-flowtype to v4. The breaking change is ESLint upgraded to v6. https://github.com/gajus/eslint-plugin-flowtype/releases/tag/v4.0.0

[lukyth]

I'll upgrade those two then.

[tonix-tuft]

I still get the warning though. Is there a fix? (I have the eslint-plugin-react-hooks version ^2.3.0 installed)

npm WARN [email protected] requires a peer of rollup@^0.x but none is installed. You must install peer dependencies yourself.

[xianghongai]

Warning appears, but does not affect project operation

warning antd > babel-runtime > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning antd > rc-tree-select > rc-trigger > rc-animate > fbjs > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning react-scripts > jest > jest-cli > jest-config > jest-environment-jsdom > jsdom > [email protected]: use String.prototype.padStart()
warning stylelint > postcss-markdown > remark > unified > @types/vfile > @types/[email protected]: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.
[2/4] Fetching packages...
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning "react-scripts > [email protected]" has incorrect peer dependency "[email protected]".
warning "react-scripts > @typescript-eslint/eslint-plugin > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
warning " > [email protected]" has incorrect peer dependency "eslint-plugin-react-hooks@^1.7.0".
[4/4] Building fresh packages...

[tonix-tuft]

So we can we safely ignore, right?

[daveisfera]

Yes, we've been using it for a while without any noticeable problems, but it still would be nice to get this fixed to avoid the warnings

[tonix-tuft]

Thank you for the feedback!