Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds png favicons to static folder as example #413

Closed

Conversation

mikaelbr
Copy link

@mikaelbr mikaelbr commented Aug 9, 2016

Refering to existing, open, PR: #226: Adds example files to possible new static folder as a means of self documentation. Keeping the "no configuration" principle in mind, I think it should also be straight forward to use without reading too much documentation and having hidden magical features.

I thought it would be easier to be able to merge this in to the existing PR, instead of just writing a comment about it (#226 (comment)). Feel free to close it if unnecessary and sorry for the overhead in that case 🍰

This helps document doing things like discussed in #28 (comment)

@ghost ghost added the CLA Signed label Aug 9, 2016
@gaearon gaearon added this to the 0.3.0 milestone Aug 22, 2016
@ghost ghost added the CLA Signed label Aug 22, 2016
@gaearon gaearon modified the milestones: 0.4.0, 0.3.0 Sep 1, 2016
@ghost ghost added the CLA Signed label Sep 1, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2016

Thanks for the PR. I realized #226 is not the way I want to do it, so passing on this. I also think I’d rather avoid creating many files by default. However I used your example in the documentation I merged as part of #551 so thank you!

@gaearon gaearon closed this Sep 2, 2016
@gaearon gaearon removed this from the 0.4.0 milestone Sep 2, 2016
@mikaelbr
Copy link
Author

mikaelbr commented Sep 2, 2016

Thanks for the update! Have a good weekend 🎉

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants