Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contentBase for serving assets from src directory in development mode. #506

Closed
wants to merge 1 commit into from

Conversation

aranajhonny
Copy link

@aranajhonny aranajhonny commented Aug 27, 2016

content-base #503 posible solution

@ghost
Copy link

ghost commented Aug 27, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost ghost added the CLA Signed label Aug 27, 2016
@tal
Copy link

tal commented Aug 27, 2016

As currently designed images in the root directory seem to be copied over like the favicon, i was gonna look into how that's setup. I think it's a cleaner solution to have a public foloder for all static assets.

@ghost
Copy link

ghost commented Aug 27, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Aug 28, 2016

Please also see #226, #413, #428.

I don’t think it’s a good idea to just make everything in src accessible as content because it will also mean we have to copy the entire src directory into the build folder, or builds would be broken.

@gaearon gaearon closed this Aug 28, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants