Closed
Conversation
It was only used in one location and did not actually encapsulate the full argument generation.
The type was no longer used to encapsulate values across function boundaries.
The struct was effectively unused.
The condition was never false
Inline _compile_module_args
The same flags are already part of `packages_info.packagedb_args`.
- add package `path` projection to `HaskellPackageDbTSet`
…tadata.py` This adds the given directory to the `PATH` of the environment when calling ghc.
Add binaries from haskell packages to PATH
If `haskell_toolchain.packages` is falsy then the `else` branch would fail.
To avoid collision with pkgname
Upgrade buck2 to version 2024-10-15
use -j in haskell_metadata action * parallel downsweep * weight = 8 for haskell_metadata run
The arg list is too long, so it needs to be wrapped in argfile. * Use argfile for stub dir copy if use_argfile_at_link is on. * at argfile doesn't work on linux shell. so in more portable way.
Local actions can upload to cache with allow_cache_upload on. * allow_cache_upload for compile action * link also allows cache upload.
This is not working for remote actions on RE.
Prepare for RE on MacOS
facebook-github-bot
added
the
CLA Signed
Author
|
sorry. it's a mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Torsten's latest change.