Skip to content

Base doesn't have to be special#40

Merged
wavewave merged 1 commit intomercuryfrom
wavewave/no-more-special-base
Oct 30, 2024
Merged

Base doesn't have to be special#40
wavewave merged 1 commit intomercuryfrom
wavewave/no-more-special-base

Conversation

@wavewave
Copy link
Copy Markdown
Collaborator

No description provided.

@wavewave wavewave force-pushed the wavewave/optional-pkgname branch from d5551b9 to aed5ba0 Compare September 10, 2024 04:52
@wavewave wavewave force-pushed the wavewave/no-more-special-base branch 2 times, most recently from 9440822 to 5879544 Compare September 12, 2024 16:19
@wavewave wavewave force-pushed the wavewave/optional-pkgname branch from aed5ba0 to 1c6cc18 Compare September 12, 2024 16:20
@wavewave
Copy link
Copy Markdown
Collaborator Author

Without this patch, we have this very cryptic error when a library does not add base to dependency.

BUILD FAILED
Traceback (most recent call last):
  File <builtin>, in <module>
  * prelude/haskell/compile.bzl:755, in _dynamic_do_compile_impl
      module_tsets[module_name] = _compile_module(
  * prelude/haskell/compile.bzl:624, in _compile_module
      fail("Unknown library dependency '{}'. Add the library to the `deps` attribut...
error: fail: Unknown library dependency 'base'. Add the library to the `deps` attribute
   --> prelude/haskell/compile.bzl:624:13
    |
624 |             fail("Unknown library dependency '{}'. Add the library to the `deps` attribute".format(dep_pkgname))
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |

@wavewave wavewave force-pushed the wavewave/optional-pkgname branch from 1c6cc18 to 3983076 Compare September 24, 2024 23:10
@wavewave wavewave force-pushed the wavewave/no-more-special-base branch from 5879544 to c2198e3 Compare September 24, 2024 23:12
@wavewave wavewave force-pushed the wavewave/optional-pkgname branch from 3983076 to cc77db0 Compare October 3, 2024 13:10
@wavewave wavewave force-pushed the wavewave/no-more-special-base branch 2 times, most recently from 8f5f116 to 403c8e4 Compare October 9, 2024 20:52
@wavewave wavewave changed the base branch from wavewave/optional-pkgname to mercury October 9, 2024 20:53
@wavewave wavewave marked this pull request as ready for review October 9, 2024 20:53
@wavewave wavewave requested review from aherrmann and avdv October 9, 2024 20:53
Copy link
Copy Markdown

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yes, that makes sense.

@wavewave wavewave force-pushed the wavewave/no-more-special-base branch from 403c8e4 to 97d5d1b Compare October 30, 2024 14:10
@wavewave wavewave merged commit 1bc53ba into mercury Oct 30, 2024
@lf- lf- deleted the wavewave/no-more-special-base branch September 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants