Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No static method loadLibrary in class #13

Closed
tyronen opened this issue Jul 6, 2018 · 17 comments
Closed

No static method loadLibrary in class #13

tyronen opened this issue Jul 6, 2018 · 17 comments

Comments

@tyronen
Copy link

tyronen commented Jul 6, 2018

(Hi @passy, if you're reading this, good to 'see' you again.)

This was previously reported in #10. I get https://pastebin.com/R5zfJtNn when starting up our app. Occurs with 0.5.0 and also with 0.4.1, but not with 0.3.0. Rebooting the Mac, as advised in that issue, did not help. We didn't attempt running with Windows.

Repro steps:

Our app had been running fine with SoLoader 0.4.1 and Fresco 1.9.0. We were doing a lazy-init of SoLoader; it is initialized by Fresco, and we didn't initialize Fresco until loading the first view with an image.

Lately we tried to add Sonar to the app. This requires calling SoLoader.init directly in the Application.onCreate method. This craps out.

The workaround is to downgrade to 0.3.0, but hopefully this can be fixed long term.

@cristianonescu
Copy link

@tyronen did you figured this out? I'm also having this error

@passy
Copy link
Member

passy commented Jul 17, 2018

Hey! Sorry for the slow response. I'm not entirely sure where this would come from. I don't have a good repro for this, so the best thing I can offer right now is to just publish another release based off master and see if that does anything.

@passy
Copy link
Member

passy commented Jul 17, 2018

I've put up a 0.5.1 which should trickle through the Maven Central release process within the next hour or so. It would be great to know if that makes any difference at all for you two.

@michalgr
Copy link
Contributor

Hi @tyronen :)

The error message complains about lack of void loadLibrary(String) method. Well, it is indeed gone as of 9169960#diff-be862dcc6d9e7bd0e7fe754df40a9bca. Seems that your app includes libraries that were compiled against different versions of SoLoader interface.

@passy
Copy link
Member

passy commented Jul 17, 2018

Ahh, thanks for the explanation, @michalgr!

@michalgr
Copy link
Contributor

The interface changed between 4.1 and 5.0. Fresco pulls in SoLoader 5.0 and Sonar pulls in 4.1 and we have a disaster.

Valuable lesson for me: do not let public API to change. I am sorry for that.

@passy: can we update Sonar deps and organize a new release ?

@passy
Copy link
Member

passy commented Jul 17, 2018

@michalgr Yes, I'll do that now.

passy added a commit to facebook/flipper that referenced this issue Jul 17, 2018
Summary:
See facebook/SoLoader#13.

Test Plan:
./gradlew :sample:installDebug
@Gadigg
Copy link

Gadigg commented Jul 17, 2018

Just started having this problem too a few hours ago..
Can't believe I caught this thread live

@passy after your PR get's approved it should be resolved after a gradle sync?

facebook-github-bot pushed a commit that referenced this issue Jul 17, 2018
Summary:
New release. No notable changes apart from build updates.

Re: #13

Reviewed By: muraziz

Differential Revision: D8875920

fbshipit-source-id: 949d819c005138f8cc5a14a5188fb4546d68689a
@passy
Copy link
Member

passy commented Jul 17, 2018 via email

@cristianonescu
Copy link

@passy any ideea how soon will this happen? When will we be able to pass this? 😭

@passy
Copy link
Member

passy commented Jul 17, 2018

@cristianonescu The Sonar release? I can do that tomorrow.

@patrickkempff
Copy link

patrickkempff commented Jul 18, 2018

Related react-native issue: facebook/react-native#20242

facebook-github-bot pushed a commit to facebook/flipper that referenced this issue Jul 18, 2018
Summary:
See facebook/SoLoader#13.
Pull Request resolved: #159

Reviewed By: jknoxville

Differential Revision: D8876179

Pulled By: passy

fbshipit-source-id: 0965f9c952410bf8f4fec80b715dd93b5c1a8918
@passy
Copy link
Member

passy commented Jul 18, 2018

New Sonar release is out as 0.6.12.

@passy
Copy link
Member

passy commented Jul 19, 2018

Still working on the long tail of this. Released 1.9.0 of Yoga today which uses the new version of SoLoader will release 0.19.0 of Litho tomorrow which will have both SoLoader >= 0.5.0 and Yoga 1.9.0 as dependency.

@gengjiawen
Copy link
Contributor

0.5.1 still has this issue.

@passy
Copy link
Member

passy commented Jul 21, 2018

@gengjiawen The SoLoader package is fine. You have an old dependency that is linked against an older version of SoLoader and are mixing it with a > 0.5.1. I'm closing this issue now because I've updated all the packages I have any control over.

@passy passy closed this as completed Jul 21, 2018
@gengjiawen
Copy link
Contributor

@passy Nope, You can see facebook/react-native#20325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants