Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to soloader 0.5.1 #20323

Closed
hramos opened this issue Jul 20, 2018 · 3 comments
Closed

Upgrade to soloader 0.5.1 #20323

hramos opened this issue Jul 20, 2018 · 3 comments
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.

Comments

@hramos
Copy link
Contributor

hramos commented Jul 20, 2018

Environment

[skip envinfo]

Description

SoLoader had an ABI-breaking change in 0.5.0.

Because React Native links against SoLoader, this can cause really frustrating experiences for our users because as soon as you mix two or more dependencies built against pre- 0.5 and post-0.5 releases, you end up with errors like

java.lang.NoSuchMethodError: No static method loadLibrary(Ljava/lang/String;)V in class Lcom/facebook/soloader/SoLoader; or its super classes (declaration of 'com.facebook.soloader.SoLoader' appears in /data/app/com.someapp.android.someapp-1/base.apk:classes2.dex)

React Native is using SoLoader 0.3.0 at the moment.

Reproducible Demo

See #20242 where a handful of people in the comments ran into the same issue.

Solution

Update React Native's SoLoader dependency to 0.5.0 or newer.

@hramos hramos added Core Team Platform: Android Android applications. Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. labels Jul 20, 2018
@hramos
Copy link
Contributor Author

hramos commented Jul 20, 2018

cc @dulmandakh @gengjiawen this might be as simple as updating the one file

@passy
Copy link
Member

passy commented Jul 20, 2018

Buck dependency, too, I would imagine.

@gengjiawen
Copy link
Contributor

@hramos I have finished the pr. But not simply update update the version :). @passy and I have work together to fix related dependency issue with fresco.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 31, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. Platform: Android Android applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants