Updated target to netcoreapp3.0

[ncave]

No description provided.

[alfonsogarciacaro]

Thanks @ncave! Have you noticed any performance improvements when upgrading to netcore 3? I was considering to postpone the upgrade until Fable 3, but maybe it's better to just do it with a minor release. I'm concerned that some users may not have netcore 3 installed yet though so latest version wouldn't run in their machines (we could add a version check before running Fable.Cli.dll to prevent this though).

[ncave]

@alfonsogarciacaro netcore 3.0 works great out of the box, I don't see a lot of performance improvement for Fable, but that's probably because F# and FCS are not using more of netcore 3.0 features (yet). It's up to you, but this is an official release and is the version that people get by default when they install .NET Core. Or you can wait until 3.1 (LTS) is released, but I don't think much it's going to change, so we might as well switch now. In any case there is no point of doing 2.2 anymore as it is going away.

[ncave]

@alfonsogarciacaro Travis CI fail is possibly related to #1910, although it works fine for me on WSL/Ubuntu 18.04.
Perhaps removing this line will fix it?

[alfonsogarciacaro]

Hmm, it seems the RuntimeFrameworkVersion is already removed in this PR but it's still failing in Travis. #1910 seems to be about running the current Fable version in a Linux machine with dotnet SDK 3 installed. Looks a bit like #1807.

IIRC I originally added RuntimeFrameworkVersion to prevent MSBuild from implicitly selecting the runtime version of the dotnet SDK in my machine which caused problems, see #963.

I hate when they release a new netcore version and then everything starts to fail... 😬

[forki]

@alfonsogarciacaro I don't think it's required to move to dotnet core 3 with the project in minor. But the roll forward thing (described in #1910) would be really appreciated. Right now we can't run fable on sdk 3

[ncave]

@alfonsogarciacaro We may not be completely out of the woods yet, seeing that in Travis fable-compiler v2.4.2 works fine when targeting netcoreapp2.1 on sdk: 3.0.100, but not when targeting netcoreapp3.0 on sdk: 3.0.100.

[alfonsogarciacaro]

Well, given that the app is working with the netcoreapp2.1 target now even if the user only has netcore 3 installed in their computer, I guess there's no rush to upgrade to netcoreapp3. We can keep the PR open and wait until either a new dotnet SDK or something in Travis fixes the issue. Or we can also wait until netcoreapp3.1 to get LTS support.

[ncave]

@alfonsogarciacaro My point was, what if somebody is trying to compile with Fable a project that targets netcoreapp3.0 on sdk 3.0, perhaps there is still an issue (not on Windows, but still).
But yes, this PR can wait until 3.1, I'll close it.

[forki]

@ncave what would that do? Would fable treat them differently? IIRC I always have netstandard as target framework for fable. Is that wrong?

[ncave]

@forki No, nothing like that, I was just saying that the Travis logs in this PR may be indicative of a potential issue when compiling projects targeting netcoreapp3.0 on sdk 3.0.
Somebody should just try that on a non-windows machine or VM.

[alfonsogarciacaro]

Yes, I usually recommend to target netstandard2.0 (I think this also avoids issues with FSharp.Core references) as Fable projects don't need to be actual dotnet apps. But I guess @ncave is thinking in Fable projects that are intended to become node apps and use the EntryPointAttribute (like fable-compiler-js itself). In those cases you do need to target netcoreapp.

[forki]

Ah ok. Thanks Alfonso Garcia-Caro <[email protected]> schrieb am Mi., 25. Sep. 2019, 22:28:

…

Yes, I usually recommend to target netstandard2.0 (I think this also avoids issues with FSharp.Core references) as Fable projects don't need to actual dotnet apps. But I guess @ncave <https://github.com/ncave> is thinking in Fable projects that are intended to become node apps and use the EntryPointAttribute (like fable-compiler-js itself). In those cases you do need to target netcoreapp. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1909?email_source=notifications&email_token=AAAOANEPQXXK23TGR3UJ5O3QLPCXHA5CNFSM4IZXLR62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7TH3PY#issuecomment-535199167>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAOANF77OPU6PL3LRKUI3DQLPCXHANCNFSM4IZXLR6Q> .