-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running fable on linux dotnet core 3 fails without details #1910
Comments
I assume it needs "roll forward" trick. Corresponding PR in Paket: fsprojects/Paket#3635 More details: https://github.com/dotnet/designs/blob/master/accepted/runtime-binding.md |
Hi @forki! Thanks for the report and the links. According to the roll forwarding rules in the document you linked, dotnet SDK will only forward the runtime minor version by default. Can you please try by setting the environmental variable |
Great, thanks a lot for confirming! I published fable-compiler 2.4.0 with the |
I assume the property in 6452101#diff-10d392ecb95787a8f3b4111d67ad744eR8 is only valid for projects that are built with dotnet SDK 3 or even need to be netcoreapp3.0 (which I don't hope). |
I used dotnet SDK 2.1.403. It's been a while since I haven't upgraded the global.json in Fable repo because last time I did there were problems. I can try upgrading to dotnet SDK 3 but still compile it as netcore2.1 which is the only LTS runtime at the moment. |
Yes that's what we should try next. My assumption is the new sdk will see the property and fo the right thing and still compile it to netcore2.1 |
Ok, done :) fable-compiler is built with dotnet SDK 3.0.100 (still targets netcoreapp2.1), I hope we're more lucky now 🤞 |
FYI there is a way without upgrading: https://github.com/fsharp/FAKE/pull/2372/files |
Yes that's what I linked above.
Matthias Dittrich <[email protected]> schrieb am Mi., 25. Sep. 2019,
13:18:
… FYI there is a way without upgrading:
https://github.com/fsharp/FAKE/pull/2372/files
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1910?email_source=notifications&email_token=AAAOANDN3SYSGRDRMCGHJ43QLNCG5A5CNFSM4IZ4C4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RRAKA#issuecomment-534974504>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANG2WHOF4L7I5BQ572DQLNCG5ANCNFSM4IZ4C4IQ>
.
|
Hopefully fable-compiler 2.4.1 works, I'd prefer to avoid MSBuild tricks that are not well documented. The link that @forki also posted above discourages the But it seems I've managed to break Travis now (I broke Appveyor a couple of commits ago) so now we have a Fable version in the wild with CI broken :/ |
Afaik that are different things. Your link was a msbuild property, but afaik that property is not supported on SDK < 3. Using the runtime json is basically what the msbuild property does. Using |
I linked to fsprojects/Paket#3635 |
Ok sorry I'm quiet now :) |
@ncave just made me realize they've "fixed" the behavior of the |
It works! Hurray |
Unfortunately it does not say what's going wrong
The text was updated successfully, but these errors were encountered: