Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Change Fisher to purely PyTorch #148

Merged
merged 28 commits into from
Nov 29, 2024
Merged

[ADD] Change Fisher to purely PyTorch #148

merged 28 commits into from
Nov 29, 2024

Conversation

f-dangel
Copy link
Owner

Review after #142, #145, #146, #147.

@f-dangel f-dangel marked this pull request as ready for review November 27, 2024 15:58
@f-dangel f-dangel requested a review from runame November 27, 2024 15:58
@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12088845626

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 11 (54.55%) changed or added relevant lines in 2 files are covered.
  • 50 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.2%) to 89.542%

Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/fisher.py 5 10 50.0%
Files with Coverage Reduction New Missed Lines %
curvlinops/examples/utils.py 10 31.25%
curvlinops/fisher.py 40 25.76%
Totals Coverage Status
Change from base Build 12053715391: -3.2%
Covered Lines: 1524
Relevant Lines: 1702

💛 - Coveralls

Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One of the examples is still broken though, I think you have to call .to_scipy() here.

@f-dangel f-dangel merged commit 9cfdd40 into main Nov 29, 2024
13 checks passed
@f-dangel f-dangel deleted the fisher-linop branch November 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants