Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Change (transposed) Jacobian to purely PyTorch #147

Merged
merged 23 commits into from
Nov 27, 2024
Merged

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Oct 27, 2024

Review after #142, #145, #146.

This introduces an attribute FIXED_DATA_ORDER, which will make sure that the data loader is deterministic when set to True (which is the case for the Jacobians). This will address #75 in a future PR.

@f-dangel f-dangel marked this pull request as draft October 27, 2024 16:23
@f-dangel f-dangel changed the title [ADD] Implement (transposed) Jacobian as purely PyTorch [ADD] Change (transposed) Jacobian to purely PyTorch Oct 27, 2024
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12053712305

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 106 of 112 (94.64%) changed or added relevant lines in 3 files are covered.
  • 57 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-2.4%) to 89.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/_torch_base.py 68 74 91.89%
Files with Coverage Reduction New Missed Lines %
curvlinops/_base.py 1 83.69%
curvlinops/examples/utils.py 10 31.25%
curvlinops/fisher.py 46 26.47%
Totals Coverage Status
Change from base Build 11944028535: -2.4%
Covered Lines: 1527
Relevant Lines: 1706

💛 - Coveralls

@f-dangel f-dangel marked this pull request as ready for review November 21, 2024 01:10
@runame runame self-requested a review November 26, 2024 13:15
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

curvlinops/_torch_base.py Outdated Show resolved Hide resolved
curvlinops/_torch_base.py Outdated Show resolved Hide resolved
curvlinops/jacobian.py Show resolved Hide resolved
curvlinops/jacobian.py Show resolved Hide resolved
@f-dangel f-dangel merged commit a4301e8 into main Nov 27, 2024
12 of 13 checks passed
@f-dangel f-dangel deleted the jacobian-linop branch November 27, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants