-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for setting video settings, moved to pnpm, fixed 2nd stream reconnection #39
Open
Andriiklymiuk
wants to merge
33
commits into
ezranbayantemur:master
Choose a base branch
from
Andriiklymiuk:videoSettings_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18,665
−29
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
3abe6cb
Bump HaishinKit to 1.4.3
Andriiklymiuk e300f2c
Fix publishing on ios on 2nd try
Andriiklymiuk a2c412e
Remove removeFromSuperview as it is just log func
Andriiklymiuk 5278476
Fix is muted
Andriiklymiuk 5306d5e
Added removeFromSuperview back
Andriiklymiuk 165cfa0
Add setVideoSettings to set custom video quality
Andriiklymiuk 9049ee7
Use common videoSettings variable
Andriiklymiuk 235022e
Added videoSettings variable
Andriiklymiuk 9317089
Revert HaishinKit to 1.2.7
Andriiklymiuk 2f04f15
Fix front camera mirror state
Andriiklymiuk 11037d1
Updated setting settings for video
Andriiklymiuk 90dd8ba
Remove unsupported multicamera detach
Andriiklymiuk 72c28ac
Added missing import
Andriiklymiuk d5883c1
Fix styling
Andriiklymiuk f8b6915
Add videoSettings and setVideoSettings to docs
Andriiklymiuk 58fbb70
Fixed example
Andriiklymiuk fb66823
Fix wrong videoSettings name
Andriiklymiuk ca5003f
Added missing stream status
Andriiklymiuk a7f0197
Added rtmpError handler
Andriiklymiuk e99b3ee
Remove publish
Andriiklymiuk 0191111
Remove unnecessary type declaration
Andriiklymiuk 684397c
Remove test from lib built library
Andriiklymiuk 2bf462e
Remove test folders from lib
Andriiklymiuk ec2a521
Build script
Andriiklymiuk dab4244
Update tsconfig to remove old config
Andriiklymiuk dfda445
Add generated files to ignore
Andriiklymiuk 415b40e
Ignore test folder in build
Andriiklymiuk 40360b5
Add pack scripts
Andriiklymiuk 683a961
Update deletePackage
Andriiklymiuk a477760
Added pnpm
Andriiklymiuk af69c45
Added shortcut with make
Andriiklymiuk becb9a3
Remove unnecessary prepare
Andriiklymiuk 2cf4570
Fix dev build
Andriiklymiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update tsconfig to remove old config
commit dab42444d5abc10bde1837ec5b5506c177e2a191
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've delete the newline on the bottom