Added support for setting video settings, moved to pnpm, fixed 2nd stream reconnection #39
+18,665
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
created react-native-publisher, till we are waiting for approval. You can also use patch-package |
|
Hello @Andriiklymiuk thanks for the PR and contribution. |
Comment on lines
+2
to
+10
| import { NativeModules, ViewStyle } from 'react-native'; | ||
| import PublisherComponent, { | ||
| type DisconnectType, | ||
| type ConnectionFailedType, | ||
| type ConnectionStartedType, | ||
| type ConnectionSuccessType, | ||
| type NewBitrateReceivedType, | ||
| type StreamStateChangedType, | ||
| type BluetoothDeviceStatusChangedType, | ||
| DisconnectType, | ||
| ConnectionFailedType, | ||
| ConnectionStartedType, | ||
| ConnectionSuccessType, | ||
| NewBitrateReceivedType, | ||
| StreamStateChangedType, | ||
| BluetoothDeviceStatusChangedType, |
There was a problem hiding this comment.
Why did you remove the type aliases?
| @@ -24,4 +27,4 @@ | |||
| "strict": true, | |||
| "target": "esnext" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Looks like you've delete the newline on the bottom
| @@ -96,6 +101,9 @@ const RTMPPublisher = forwardRef<RTMPPublisherRefProps, RTMPPublisherProps>( | |||
| const setAudioInput = (audioInput: AudioInputType) => | |||
| RTMPModule.setAudioInput(audioInput); | |||
|
|
|||
| const setVideoSettings = async (videoSettings: VideoSettingsType) => | |||
There was a problem hiding this comment.
async keyword is unnecessary on here.
| @@ -27,9 +31,11 @@ | |||
| "lint": "eslint \"**/*.{js,ts,tsx}\"", | |||
| "prepare": "bob build", | |||
| "release": "dotenv release-it --", | |||
| "example": "yarn --cwd example", | |||
There was a problem hiding this comment.
Why did you delete example script?
Comment on lines
+36
to
+38
| "build": "pnpm install && pnpm pack", | ||
| "unpack": "for file in react-native-rtmp-publisher*.tgz; do tar -xzf \"$file\"; done", | ||
| "deletePackage": "rm -r package && rm -r react-native-rtmp-publisher*.tgz" |
There was a problem hiding this comment.
I think sticking on yarn is much more good idea for right now. We can consider pnpm on the future. Thanks for the suggestion 👍🏼
Can you revert this for now?
| @@ -209,6 +216,7 @@ For live stream, Youtube gives you stream url and stream key, you can place the | |||
| | `isVideoPrepared` | `Promise<boolean>` | Returns video prepare state | ✅ | ✅ | | |||
| | `isCameraOnPreview` | `Promise<boolean>` | Returns camera is on | ✅ | ❌ | | |||
| | `setAudioInput` | `Promise<AudioInputType>`| Sets microphone input | ✅ | ✅ | | |||
| |`setVideoSettings` | `Promise<VideoSettingsType>`| Sets camera quality settings| ❌ | ✅ | | |||
There was a problem hiding this comment.
It's not setting the camera quality, it's setting the video scale values. Can you update it for avoiding misunderstanding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the MR I added:
p.s. will publish separate library till these fixes are implemented (don't know if this library still supported)