ci: add a lint check to ensure all PRs pass lint too #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run
npm run lint
in CIDetails
rename the job a bit to match, and shrink the name a bit for conciseness as it didn't always fit on screen in the list of checks
this could be done in a different job as it's not necessarily required for linting to run through the entire matrix, but this is simpler for now as we don't have a further need for separate jobs
Next Steps
@typescript-eslint
-- this might be good for a community contribution?prettier
as well instead of relying oneditorconfig
etc (a lot of style things are currently missed bylint
; something I notice in particular as I typically use single quotes and no semi-colons and need to adjust in this codebase)