Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a lint check to ensure all PRs pass lint too #327

Merged
merged 1 commit into from
May 16, 2022

Conversation

agilgur5
Copy link
Collaborator

Summary

Run npm run lint in CI

Details

  • rename the job a bit to match, and shrink the name a bit for conciseness as it didn't always fit on screen in the list of checks

  • this could be done in a different job as it's not necessarily required for linting to run through the entire matrix, but this is simpler for now as we don't have a further need for separate jobs

    • and no need to re-run install etc, and the tests are fast anyway currently, so no perf need there either

Next Steps

  1. Still need to upgrade to @typescript-eslint -- this might be good for a community contribution?
  2. Could add a formatter like prettier as well instead of relying on editorconfig etc (a lot of style things are currently missed by lint; something I notice in particular as I typically use single quotes and no semi-colons and need to adjust in this codebase)

- rename the job a bit to match, and shrink the name a bit for
  conciseness as it didn't always fit on screen in the list of checks

- this could be done in a different job as it's not necessarily required
  for linting to run through the entire matrix, but this is simpler for
  now as we don't have a further need for separate jobs
  - and no need to re-run install etc, and the tests are fast anyway
    currently, so no perf need there either
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label May 14, 2022
@ezolenko ezolenko merged commit bbb4f4f into ezolenko:master May 16, 2022
@agilgur5 agilgur5 deleted the ci-add-lint branch July 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants