Skip to content

Commit

Permalink
ci: add a lint check to ensure all PRs pass lint too (#327)
Browse files Browse the repository at this point in the history
- rename the job a bit to match, and shrink the name a bit for
  conciseness as it didn't always fit on screen in the list of checks

- this could be done in a different job as it's not necessarily required
  for linting to run through the entire matrix, but this is simpler for
  now as we don't have a further need for separate jobs
  - and no need to re-run install etc, and the tests are fast anyway
    currently, so no perf need there either
  • Loading branch information
agilgur5 authored May 16, 2022
1 parent 60f3489 commit bbb4f4f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:
branches: [ master ]

jobs:
build-and-test:
name: Build & Test on Node ${{ matrix.node-version }} and ${{ matrix.os }}
lint-build-test:
name: Lint, Build, Test - Node ${{ matrix.node-version }}, ${{ matrix.os }}

runs-on: ${{ matrix.os }}
strategy:
Expand All @@ -27,6 +27,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
- run: npm run lint
- run: npm run build
- run: npm run build-self
- run: npm run build-self
Expand Down

0 comments on commit bbb4f4f

Please sign in to comment.