-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unsupported Node.js, bump major, update pug #244
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,9 @@ | ||
language: node_js | ||
node_js: | ||
- "0.10" | ||
- "0.12" | ||
- "1.8" | ||
- "2.5" | ||
- "3.3" | ||
- "4.9" | ||
- "5.12" | ||
- "6.16" | ||
- "7.10" | ||
- "8.15" | ||
- "9.11" | ||
- "8" | ||
- "10" | ||
- "12" | ||
- "13" | ||
matrix: | ||
fast_finish: true | ||
sudo: false | ||
|
@@ -22,33 +15,6 @@ before_install: | |
- | | ||
# Skip updating shrinkwrap / lock | ||
npm config set shrinkwrap false | ||
# Setup Node.js version-specific dependencies | ||
- | | ||
# eslint for linting | ||
# - remove on Node.js < 6 | ||
if [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -lt 6 ]]; then | ||
node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \ | ||
grep -E '^eslint(-|$)' | \ | ||
xargs npm rm --save-dev | ||
fi | ||
- | | ||
# mocha for testing | ||
# - use 3.x for Node.js < 4 | ||
# - use 5.x for Node.js < 6 | ||
if [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -lt 4 ]]; then | ||
npm install --save-dev [email protected] | ||
elif [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -lt 6 ]]; then | ||
npm install --save-dev [email protected] | ||
fi | ||
- | | ||
# supertest for http calls | ||
# - use 2.0.0 for Node.js < 4 | ||
# - use 3.4.2 for Node.js < 6 | ||
if [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -lt 4 ]]; then | ||
npm install --save-dev [email protected] | ||
elif [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -lt 6 ]]; then | ||
npm install --save-dev [email protected] | ||
fi | ||
# Update Node.js modules | ||
- | | ||
# Prune and rebuild node_modules | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,9 @@ | ||
environment: | ||
matrix: | ||
- nodejs_version: "0.10" | ||
- nodejs_version: "0.12" | ||
- nodejs_version: "1.8" | ||
- nodejs_version: "2.5" | ||
- nodejs_version: "3.3" | ||
- nodejs_version: "4.9" | ||
- nodejs_version: "5.12" | ||
- nodejs_version: "6.16" | ||
- nodejs_version: "7.10" | ||
- nodejs_version: "8.15" | ||
- nodejs_version: "9.11" | ||
- nodejs_version: "8" | ||
- nodejs_version: "10" | ||
- nodejs_version: "12" | ||
- nodejs_version: "13" | ||
cache: | ||
- node_modules | ||
install: | ||
|
@@ -29,24 +22,6 @@ install: | |
sls "^eslint(-|$)" | ` | ||
%{ npm rm --silent --save-dev $_ } | ||
# Setup Node.js version-specific dependencies | ||
- ps: | | ||
# mocha for testing | ||
# - use 3.x for Node.js < 4 | ||
# - use 5.x for Node.js < 6 | ||
if ([int]$env:nodejs_version.split(".")[0] -lt 4) { | ||
npm install --silent --save-dev [email protected] | ||
} elseif ([int]$env:nodejs_version.split(".")[0] -lt 6) { | ||
npm install --silent --save-dev [email protected] | ||
} | ||
- ps: | | ||
# supertest for http calls | ||
# - use 2.0.0 for Node.js < 4 | ||
# - use 3.4.2 for Node.js < 6 | ||
if ([int]$env:nodejs_version.split(".")[0] -lt 4) { | ||
npm install --silent --save-dev [email protected] | ||
} elseif ([int]$env:nodejs_version.split(".")[0] -lt 6) { | ||
npm install --silent --save-dev [email protected] | ||
} | ||
# Update Node.js modules | ||
- ps: | | ||
# Prune & rebuild node_modules | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"name": "express-generator", | ||
"description": "Express' application generator", | ||
"version": "4.16.1", | ||
"version": "5.0.0", | ||
"author": "TJ Holowaychuk <[email protected]>", | ||
"contributors": [ | ||
"Aaron Heckmann <[email protected]>", | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generator version matches the generated express version. Make sure to update the related version of Express as well, and you can remove this line from the PR, as npm command would then cause us to release as a diff versions since it bumps what is in the package when making the tag and publishing.