Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported Node.js, bump major, update pug #244

Closed
wants to merge 3 commits into from
Closed

remove unsupported Node.js, bump major, update pug #244

wants to merge 3 commits into from

Conversation

sam-github
Copy link

@sam-github sam-github commented Dec 6, 2019

gen: update pug to ~2.0.4

Fixes:
- https://npmjs.com/advisories/785
- Dependency on pug's -beta11


build: add Node.js 10, 12, 13, remove EOL Node.js

Bumps the package version since dropping support for Node.js versions is
semver-major.

Anyone who is still generating new express apps for out-of-support
Node.js versions (unadvisedly) can either modify the generated
dependencies after generation, or use express-generator 4.x

Bumps the package version since dropping support for Node.js versions is
semver-major.

Anyone who is still generating new express apps for out-of-support
Node.js versions (unadvisedly) can either modify the generated
dependencies after generation, or use express-generator 4.x
Fixes:
- https://npmjs.com/advisories/785
- Dependency on pug's -beta11
@sam-github sam-github changed the title gen: update pug to ~2.0.4 remove unsupported Node.js, bump major, update pug Dec 6, 2019
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the the supported versions of the generator match the same as the express supported versions. I.e. it should cover the same node.js versions express 5 does if that is what this is trying to update.

@@ -1,7 +1,7 @@
{
"name": "express-generator",
"description": "Express' application generator",
"version": "4.16.1",
"version": "5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator version matches the generated express version. Make sure to update the related version of Express as well, and you can remove this line from the PR, as npm command would then cause us to release as a diff versions since it bumps what is in the package when making the tag and publishing.

@sam-github
Copy link
Author

@dougwilson thanks for the comments.

express supports 0.10 and later, on both master and 5.x-alpha:

I'm not sure how to approach that. Dropping support for a node version should cause a package major bump, so it wouldn't be able to do this until [email protected], unless the alpha status allows dropping EOL node support?

I found: expressjs/express#2755 (comment)

When 5.0 is released it will support down to the LTS version at that time.

@dougwilson
Copy link
Contributor

It would probably go (1) land a change to some express (5, 6, whatever) that removes various Node.js versions from its matrix. Then this module would change its matrix to match that of the express version it'll drop into the package.json it produced.

@sam-github
Copy link
Author

It would probably go (1) land a change to some express (5, 6, whatever) that removes various Node.js versions from its matrix.

That PR exists: expressjs/express#3948

So, I should wait until it lands, then refresh this PR?

@dougwilson
Copy link
Contributor

Yea, if the goal of this PR is to drop Node.js versions, it should wait.

@sam-github
Copy link
Author

The goal is for generated apps to not have audit warnings, but as long as CI requires support back to 0.10, and at least one of the deps (pug) doesn't support 0.10 anymore, those two goals are not reconcilable. I'm sure deps will be updated as a matter of course, sometime, so I'll close this. Users can run npm audit fix in the meantime.

@sam-github sam-github closed this Dec 6, 2019
@sam-github sam-github deleted the non-beta-pug branch December 6, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants