Skip to content

Conversation

@UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Mar 26, 2025

What's Changed

New Contributors

Full Changelog: v2.1.0...master

@UlisesGascon
Copy link
Member Author

⚠️ @wesleytodd please double check in detail #596 as it is included in this release and I was the only reviewer

@Phillip9587
Copy link
Member

Any chance we could try to get #587 into this release?

@wesleytodd
Copy link
Member

@Phillip9587 I don't think I fully read that PR but took a quick look just now and I think we should wait on it. The code scanning had some comments (first time seeing that in action, and I think it is actually some good feedback to discuss) and we are shooting to release this asap. It has been dragging on too long and we had a sync on today's working session to try and see what we can land and what might need to go into the next patch. I can keep that tab open for tomorrow and try and give it a review, but I think if you are alright with it maybe we can wait for that one for the next patch (which we can make high priority)?

@wesleytodd
Copy link
Member

please double check in detail #596 as it is included in this release and I was the only reviewer

I am not sure I am a big fan of all the optional chaining vs just making sure we always make an options object, but I don't see anything worth blocking over. We can decide if we wanted to take a different approach in the future without any user impact so it is all good imo.

@UlisesGascon UlisesGascon merged commit 0aa4e11 into master Mar 27, 2025
12 checks passed
@UlisesGascon UlisesGascon deleted the release/2.2.0 branch March 27, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants