Wrap ActionSheet with a Modal #169
Merged
+67
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2020
Merged
Contributor
|
Hey @BrodaNoel, thanks for jumping on this -- I'm sorry I wasn't able to get something together sooner. I think an initial pattern to a) get this out for your asap, and b) not risk any issues to existing usage would be to determine this with a In the next breaking update this could be moved to the default. Thoughts? |
bradbyte
suggested changes
Apr 27, 2020
sfuqua
reviewed
Apr 28, 2020
Co-Authored-By: Brad Bumbalough <[email protected]>
BrodaNoel
commented
Apr 29, 2020
bradbyte
pushed a commit
that referenced
this pull request
May 6, 2020
# [3.7.0](v3.6.0...v3.7.0) (2020-05-06) ### Features * adds `useModal` prop wrap action sheet in a modal ([9ed955d](9ed955d)), closes [#169](#169)
Contributor
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
robertomartinez09515
added a commit
to robertomartinez09515/action-sheet-react-best-proj
that referenced
this pull request
Jul 25, 2022
# [3.7.0](expo/react-native-action-sheet@v3.6.0...v3.7.0) (2020-05-06) ### Features * adds `useModal` prop wrap action sheet in a modal ([9ed955d](expo/react-native-action-sheet@9ed955d)), closes [#169](expo/react-native-action-sheet#169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed
#164
Video
https://youtu.be/4aJ8T-M6RR0
Texts/Examples
Yeap, added.