Skip to content
This repository was archived by the owner on Jan 18, 2024. It is now read-only.

Conversation

@BrodaNoel
Copy link
Contributor

No description provided.

@BrodaNoel
Copy link
Contributor Author

PS.: If you can also review expo/react-native-action-sheet#169, will be awesome :D

@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #2006 into master will increase coverage by 7.03%.
The diff coverage is n/a.

Flag Coverage Δ
#babelPresetCli 100.00% <ø> (ø)
#config 60.64% <ø> (?)
#expoCli 29.09% <ø> (ø)
#expoCodemod 83.81% <ø> (ø)
#jsonFile 65.49% <ø> (ø)
#metroConfig 58.83% <ø> (ø)
#packageManager 16.67% <ø> (ø)
#plist 70.64% <ø> (ø)
#pwa ?
#schemer 69.88% <ø> (?)
#uriScheme 32.05% <ø> (ø)
#webpackConfig 53.41% <ø> (ø)
#xdl 23.37% <ø> (ø)
@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
+ Coverage   38.14%   45.16%   +7.03%     
==========================================
  Files          58      101      +43     
  Lines        3029     4181    +1152     
  Branches      718      998     +280     
==========================================
+ Hits         1155     1888     +733     
- Misses       1353     1598     +245     
- Partials      521      695     +174     

@brentvatne
Copy link
Member

heya! thanks for this. as for the action sheet pr, i will leave that to @bradbumbalough as he maintains that repo 🌟

@brentvatne brentvatne merged commit e0ae147 into expo:master Apr 27, 2020
@BrodaNoel BrodaNoel deleted the BrodaNoel-patch-1 branch April 27, 2020 04:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants