This repository was archived by the owner on Jan 18, 2024. It is now read-only.
feat(dev-server): support new API for Expo SDK 45 #4306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
@react-native-community/cli-server-apifrom the project instead of vendoring. This will ensure the installed version works with the installedmetropackage.attachToServerexists, then attach using the legacy API, otherwise use the new API.Test Plan
npx react-native init, a couple hours later I was able to runnpx react-native run-iosthennpx react-native start-- pressingrworks but pressingddoes not work.expo start --dev-clientthen pressedrto reload --ddidn't work in Expo CLI either.expo startto ensure pressingranddstill worked as expected.