This repository was archived by the owner on Jan 18, 2024. It is now read-only.
[DO NOT MERGE] Fix websocket controls on RN 0.68 #4305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
reviewed
Apr 15, 2022
| "@expo/metro-config": "0.3.13", | ||
| "@expo/osascript": "2.0.32", | ||
| "@react-native-community/cli-server-api": "^5.0.1", | ||
| "@react-native-community/cli-server-api": "^7.0.3", |
Contributor
There was a problem hiding this comment.
We should drop this dependency and import it from the project if available like we do for metro.
EvanBacon
reviewed
Apr 15, 2022
Comment on lines
+89
to
+95
| const { | ||
| middleware, | ||
| debuggerProxyEndpoint, | ||
| messageSocketEndpoint, | ||
| eventsSocketEndpoint, | ||
| websocketEndpoints, | ||
| } = createDevServerMiddleware({ |
Contributor
There was a problem hiding this comment.
We may need to check which features are available based on the version installed and implement the new functionality only when the new features are available. Ultimately we'll drop this in SDK 46 when we drop the unversioned CLI.
Contributor
|
Closing in favor of #4306 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR isn't a ready fix, because I don't really know how this change should be introduced to the CLI.
Fixes expo-cli terminal commands does not recognise the device:
How
RN 0.67 introduced a different way of handling WebSocket connections. You can read more here -> react-native-community/cli#1560.
TL;DR
WebSockets started using a shared server. They are created with the
noServerflag right now and have to be attached to theupgradeevent like here https://github.com/websockets/ws#multiple-servers-sharing-a-single-https-server.However, by doing that we are losing the backwards compatibility.
Test Plan