-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty cursors #281
Merged
Merged
Pretty cursors #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pretty-print #281 +/- ##
================================================
- Coverage 87.90% 87.87% -0.03%
================================================
Files 72 72
Lines 15509 15632 +123
================================================
+ Hits 13633 13737 +104
- Misses 1876 1895 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexreinking
force-pushed
the
pretty-print
branch
from
November 7, 2022 14:15
60148f6
to
e44103f
Compare
alexreinking
force-pushed
the
pretty-cursors
branch
from
November 7, 2022 14:17
b2e6cbd
to
077f688
Compare
Merged
yamaguchi1024
approved these changes
Nov 7, 2022
alexreinking
force-pushed
the
pretty-cursors
branch
from
November 7, 2022 21:24
60578f0
to
0b75548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #279 and #280 are merged, this should be rebased onto
master
.Implements pretty printing for (internal) cursors. This will be useful for writing tests regarding cursors and cursor forwarding more accurately, as well as for interactive debugging.
Cursor types implemented:
Ultimately, this will be transformed such that cursors can be rendered like so. Consider this proc:
A cursor to
for i in seq(0, n)
would look like:Or to the gap before it:
The block containing
x = 1.0; _ ; x = 3.0
looks like:This way we can use golden outputs to very quickly check that cursors are correct.