Mark slow tests as such in PyTest. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run pytest with `pytest -m "not slow"` to run only the fast tests. With this, the whole test suite takes about a minute on my laptop. Works well with `-n $(nproc)` for parallelism. Does NOT work well with `--update-golden` because all golden outputs should typically be updated at once.
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 87.86% 87.83% -0.04%
==========================================
Files 72 72
Lines 15537 15542 +5
==========================================
- Hits 13652 13651 -1
- Misses 1885 1891 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yamaguchi1024
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
@alexreinking This looks great! This still runs Gemmini tests by default, right?
|
@yamaguchi1024 - yes, it's all opt-in and doesn't change how anything currently works. Does not affect CI at all. This just adds a label to the tests that take more than 30 seconds on my machine so that they can be manually excluded. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a developer convenience.
Run pytest with
pytest -m "not slow"to run only the fast tests. With this, the whole test suite takes about a minute on my laptop. Works well with-n $(nproc)for parallelism. Does NOT work well with--update-goldenbecause all golden outputs should typically be updated at once.