Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests starting with letters (R-Z) to use assertj #2513

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Update tests starting with letters (R-Z) to use assertj #2513

merged 5 commits into from
Oct 6, 2023

Conversation

pavanbaloju
Copy link
Contributor

pull request for (#2147 )

In this PR, the following tests have been updated to use assertj

  1. RailFenceCipherTest.java
  2. RaindropConverterTest.java
  3. RationalTest.java
  4. RectangleCounterTest.java
  5. RestApiTest.java
  6. ReverseStringTest.java
  7. RobotTest.java
  8. RomanNumeralsTest.java
  9. RunLengthEncodingTest.java
  10. MatrixTest.java
  11. ScrabbleScoreTest.java
  12. SeriesTest.java
  13. SieveTest.java
  14. SimpleCipherStepOneTest.java
  15. SimpleCipherStepTwoSubsitutionTest.java
  16. SpaceAgeTest.java
  17. SpiralMatrixBuilderTest.java
  18. RelationshipComputerTest.java
  19. SumOfMultiplesTest.java
  20. TournamentTest.java
  21. TwelveDaysTest.java
  22. TwoBucketTest.java
  23. VariableLengthQuantityTest.java
  24. WordCountTest.java
  25. WordSearcherTest.java
  26. WordProblemSolverTest.java
  27. YachtTest.java
  28. ZebraPuzzleTest.java

Reviewer Resources:

Track Policies

@pavanbaloju
Copy link
Contributor Author

pavanbaloju commented Oct 6, 2023 •
edited
Loading

Hi @sanderploegsma
One last PR from my side for the remaining classes. Please review!
With this I think almost all tests have been updated except the deprecated ones

@pavanbaloju pavanbaloju mentioned this pull request Oct 6, 2023
Closed
sanderploegsma
sanderploegsma approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I found one possible improvement. Could you have a look at it?

exercises/practice/simple-cipher/src/test/java/SimpleCipherStepOneTest.java Outdated Show resolved Hide resolved
@sanderploegsma sanderploegsma merged commit e0c0f90 into exercism:main Oct 6, 2023
3 checks passed
@pavanbaloju pavanbaloju deleted the update-tests-to-use-assertj-2 branch October 6, 2023 18:27
@sanderploegsma
Copy link
Contributor

Thanks again!

@pavanbaloju
Copy link
Contributor Author

Thanks and welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderploegsma sanderploegsma sanderploegsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavanbaloju @sanderploegsma