Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates tests to use assertThat instead of assertEquals #2511

Merged

Conversation

pavanbaloju
Copy link
Contributor

pull request for (#2147 )

In this Pr, all the below tests have been updated to use assertj

  1. ComplexNumberTest.java
  2. EtlTest.java
  3. FlattenerTest.java
  4. FoodChainTest.java
  5. GigasecondTest.java
  6. GoCountingTest.java
  7. GrainsTest.java
  8. GrepToolTest.java
  9. IsbnVerifierTest.java
  10. LargestSeriesProductCalculatorTest.java
  11. MatrixTest.java
  12. MeetupTest.java
  13. MicroBlogTest.java
  14. MinesweeperBoardTest.java
  15. NucleotideCounterTest.java
  16. OctalTest.java
  17. PascalsTriangleGeneratorTest.java
  18. NaturalNumberTest.java
  19. PigLatinTranslatorTest.java
  20. PokerTest.java
  21. PovTest.java
  22. PrimeFactorsCalculatorTest.java
  23. PythagoreanTripletTest.java

Reviewer Resources:

Track Policies

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🙏

@sanderploegsma sanderploegsma merged commit 7ad49a1 into exercism:main Oct 6, 2023
3 checks passed
@pavanbaloju pavanbaloju deleted the update-tests-to-use-assertj branch October 6, 2023 17:10
@pavanbaloju
Copy link
Contributor Author

LGTM! Thanks for your contribution 🙏

Thank you!

pavanbaloju added a commit to pavanbaloju/exercism-java that referenced this pull request Oct 6, 2023
* Updates tests to use assertThat instead of assertEquals

* Fix style check

* Revert deprecated exercise changes

* Fix style check

* Revert imports change
sanderploegsma pushed a commit that referenced this pull request Oct 6, 2023
* Update tests to use assertj for classes starting with letter R-Z

* Revert deprecated exercise changes

* Updates tests to use assertThat instead of assertEquals (#2511)

* Updates tests to use assertThat instead of assertEquals

* Fix style check

* Revert deprecated exercise changes

* Fix style check

* Revert imports change

* Use assertj pattern matching in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants