Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read-write access to configuration and download directories when installed as a Snap #972

Closed
wants to merge 2 commits into from
Closed

Allow read-write access to configuration and download directories when installed as a Snap #972

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
765a654
Allow read-write access to configuration and download directories.
richardneish Nov 24, 2020
90812de
Permit writes to any files in user's home directory
richardneish Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,9 @@ snapcrafts:
386: i386
apps:
exercism:
plugs: ["home", "network", "removable-media"]
plugs: ["home", "network", "removable-media","personal-files"]
plugs:
personal-files:
write:
- $HOME/.config/exercism/
- $HOME/exercism/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only the default installation directory, and should not be hard coded, i think, but should gather that from the configuration file. Otherwise we are likely going to have intermittent permission problems if the user changes the workspace.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can allow write access to any subdirectory of $HOME - would that be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that is better. Perhaps the configuration file is not yet written at this point in time, to be able to get the workspace from the configuration.