-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow read-write access to configuration and download directories when installed as a Snap #972
Conversation
We need write access to the $HOME/.config/exercism/ directory for `exercism config` and $HOME/exercism is the default download directory so we need write access there as well. This should resolve issue #945
.goreleaser.yml
Outdated
personal-files: | ||
write: | ||
- $HOME/.config/exercism/ | ||
- $HOME/exercism/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only the default installation directory, and should not be hard coded, i think, but should gather that from the configuration file. Otherwise we are likely going to have intermittent permission problems if the user changes the workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can allow write access to any subdirectory of $HOME - would that be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that is better. Perhaps the configuration file is not yet written at this point in time, to be able to get the workspace from the configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible that the ideal solution is for a tighter restriction than $HOME. However, given the installation troubles we've seen, I think it is worthwhile to merge this as-is.
Thanks for the contribution @richardneish! It should be reflected in the next release of the CLI, which should correspond with the Exercism V3 launch. The build should pass after getting merged with |
In order to merge, the build needs to pass. In order for the build to pass, we need to merge the latest changes from |
We need write access to the $HOME/.config/exercism/ directory for
exercism config
and $HOME/exercism is the default download directory so we need write access there as well.This should resolve issue #945