-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#729: Add rules_jvm_external to Bazel and add a test maven dependency #336
#729: Add rules_jvm_external to Bazel and add a test maven dependency #336
Conversation
8d203e8
to
eab45a4
Compare
b01f829
to
82b99c3
Compare
@@ -9,6 +9,36 @@ http_archive( | |||
url = "https://github.com/bazelbuild/bazel-skylib/releases/download/{}/bazel-skylib.{}.tar.gz".format(skylib_version, skylib_version), | |||
) | |||
|
|||
RULES_JVM_EXTERNAL_TAG = "4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should update, or we do this in a extra PR
https://github.com/bazelbuild/rules_jvm_external/releases/tag/6.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had tried already to update to latest version, but does not work (because of Modul stuff in Bazel).
Anyway, will be updated in #439
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but see my comment.
PS: I can't approve the PR officially, because I am the creator of it
Part of exasol/script-languages-release#729