#729: Add rules_jvm_external to Bazel and add a test maven dependency #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
force-pushed
the
refactoring/729_integrate_udf_api_java_jar_from_maven
branch
from
8d203e8
to
eab45a4
Compare
tomuben
force-pushed
the
refactoring/729_integrate_udf_api_java_jar_from_maven
branch
from
b01f829
to
82b99c3
Compare
kaklakariada
reviewed
Aug 2, 2024
tkilias
commented
Aug 5, 2024
| @@ -9,6 +9,36 @@ http_archive( | |||
| url = "https://github.com/bazelbuild/bazel-skylib/releases/download/{}/bazel-skylib.{}.tar.gz".format(skylib_version, skylib_version), | |||
| ) | |||
|
|
|||
| RULES_JVM_EXTERNAL_TAG = "4.2" | |||
There was a problem hiding this comment.
maybe we should update, or we do this in a extra PR
https://github.com/bazelbuild/rules_jvm_external/releases/tag/6.2
There was a problem hiding this comment.
Had tried already to update to latest version, but does not work (because of Modul stuff in Bazel).
Anyway, will be updated in #439
tkilias
commented
Aug 5, 2024
tomuben
approved these changes
Aug 5, 2024
tomuben
deleted the
refactoring/729_integrate_udf_api_java_jar_from_maven
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of exasol/script-languages-release#729