-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bazel #685
Labels
refactoring
Code improvement without behavior change
Comments
tomuben
added a commit
to exasol/script-languages
that referenced
this issue
Aug 14, 2024
tomuben
added a commit
that referenced
this issue
Aug 14, 2024
fixes #685 - Use new MODULE.bazel instead of WORKSPACE - Convert the base part in Script-Languages to a submodule, which then can be used from the exaudfclient in Script-Languages and Script-Languages-Release. This simplifies the packaging of the UDF client in the Script-Languages-Container as we don't need to mess around with symlinks for the binaries in the former Script-Languages Bazel package. - Convert the rules for external packages (zmq, protobuf, Python, Java,...) to be complient to the new MODULE implementation - Use MODULE dependencies were applicable - Maven - Refactor the Java BUILD file - The new version of Bazel does not support directories in the out attribute of a rule. We need to specify each single output file - Removed unnecessary rules - Pass only needed files to the filter rules - Clean up Conda flavors - Pin only given packages, but not all (already installed) packages - Remove transitive dependencies in conda package files - Test if CUDA flavors still work correctly with Pytorch and Tensorflow + Nvidia GPU - Remove dependency to OpenJDK: Bazel defines this dependency. We don't need it explicitely. --------- Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Currently, we use Bazel
5.2.0
; however version7.1.1
is already available.Acceptance Criteria
Use Latest version of Bazel in all flavors.
Needed changes
MODULE.bazel
instead ofWORKSPACE
base
part inScript-Languages
to a submodule, which then can be used from theexaudfclient
inScript-Languages
andScript-Languages-Release
. This simplifies the packaging of the UDF client in the Script-Languages-Container as we don't need to mess around with symlinks for the binaries in the formerScript-Languages
Bazel package.zmq
,protobuf
,Python
,Java
,...) to be complient to the newMODULE
implementationMODULE
dependencies were applicableJava
BUILD fileout
attribute of a rule. We need to specify each single output filePytorch
andTensorflow
+ Nvidia GPUOpenJDK
: Bazel defines this dependency. We don't need it explicitely.The text was updated successfully, but these errors were encountered: