Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bazel #685

Closed
13 tasks done
tomuben opened this issue Aug 3, 2022 · 0 comments
Closed
13 tasks done

Update Bazel #685

tomuben opened this issue Aug 3, 2022 · 0 comments
Assignees
@tomuben
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Aug 3, 2022 •
edited
Loading

Background

Currently, we use Bazel 5.2.0; however version 7.1.1 is already available.

Acceptance Criteria

Use Latest version of Bazel in all flavors.

Needed changes

  • Use new MODULE.bazel instead of WORKSPACE
    • Convert the base part in Script-Languages to a submodule, which then can be used from the exaudfclient in Script-Languages and Script-Languages-Release. This simplifies the packaging of the UDF client in the Script-Languages-Container as we don't need to mess around with symlinks for the binaries in the former Script-Languages Bazel package.
    • Convert the rules for external packages (zmq, protobuf, Python, Java,...) to be complient to the new MODULE implementation
    • Use MODULE dependencies were applicable
      • Maven
  • Refactor the Java BUILD file
    • The new version of Bazel does not support directories in the out attribute of a rule. We need to specify each single output file
    • Removed unnecessary rules
    • Pass only needed files to the filter rules
  • Clean up Conda flavors
    • Pin only given packages, but not all (already installed) packages
    • Remove transitive dependencies in conda package files
    • Test if CUDA flavors still work correctly with Pytorch and Tensorflow + Nvidia GPU
    • Remove dependency to OpenJDK: Bazel defines this dependency. We don't need it explicitely.
@tomuben tomuben added the refactoring Code improvement without behavior change label Aug 3, 2022
@tomuben tomuben mentioned this issue Aug 8, 2024
Merged
tomuben added a commit that referenced this issue Aug 8, 2024
@tomuben
#685: Updated Bazel
c14741a
tomuben added a commit to exasol/script-languages that referenced this issue Aug 14, 2024
@tomuben
#685: Update bazel (#439)
2b66372 
related to exasol/script-languages-release#685
@tomuben tomuben mentioned this issue Aug 14, 2024
Merged
8 tasks
tomuben added a commit that referenced this issue Aug 14, 2024
@tomuben @tkilias
#685: updated bazel (#942)
a3c208f 
fixes #685 

- Use new MODULE.bazel instead of WORKSPACE
  - Convert the base part in Script-Languages to a submodule, which then can be used from the exaudfclient in Script-Languages and Script-Languages-Release. This simplifies the packaging of the UDF client in the Script-Languages-Container as we don't need to mess around with symlinks for the binaries in the former Script-Languages Bazel package.
 - Convert the rules for external packages (zmq, protobuf, Python, Java,...) to be complient to the new MODULE implementation
 - Use MODULE dependencies were applicable
    - Maven
- Refactor the Java BUILD file
  - The new version of Bazel does not support directories in the out attribute of a rule. We need to specify each single output file
  - Removed unnecessary rules
  - Pass only needed files to the filter rules
 - Clean up Conda flavors
   - Pin only given packages, but not all (already installed) packages
   - Remove transitive dependencies in conda package files
   - Test if CUDA flavors still work correctly with Pytorch and Tensorflow + Nvidia GPU
   -  Remove dependency to OpenJDK: Bazel defines this dependency. We don't need it explicitely.

---------

Co-authored-by: Torsten Kilias <[email protected]>
@tomuben tomuben closed this as completed Aug 14, 2024
tomuben added a commit that referenced this issue Aug 19, 2024
@tomuben
Merge pull request #946 from exasol/develop
8850344 
Changelog:
- #729: Add rules_jvm_external to Bazel and add a test maven dependency (#730)
- #685: updated bazel (#942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomuben tomuben

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomuben