chore: remove unused flag

[tac0turtle]

Overview

[gemini-code-assist]

Summary of Changes

Hello @tac0turtle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a minor cleanup by removing an unused flag from the Docker Compose configuration for the EVM execution environment. The --ev-reth.enable flag is no longer relevant, and its removal helps maintain a clean and accurate setup, reducing potential confusion and improving overall maintainability.

Highlights

• Configuration Cleanup: Removed the --ev-reth.enable flag from the docker-compose.yml file, as it is no longer needed, streamlining the configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claude]

Claude finished @tac0turtle's task —— View job

---

Code Review Complete

I've reviewed this PR which removes the --ev-reth.enable flag across multiple configuration files and bumps the tastora dependency version. Here's my detailed analysis:

---

Overview

This PR performs cleanup by:

1. Removing the --ev-reth.enable flag from all Docker Compose and Go script configurations
2. Updating tastora dependency from v0.5.0/v0.7.1 to v0.7.3
3. Minor formatting/indentation improvements in docker-compose files

---

Critical Issue: Gemini's Concern Requires Clarification

Gemini Code Assist raised a valid concern that needs to be addressed in the PR description:

The EngineClient implementation (execution/evm/execution.go:177-187) sends custom, non-standard payload attributes in engine_forkchoiceUpdatedV3 calls:

• "transactions": Pre-built transaction list (non-standard)
• "gasLimit": Gas limit override (non-standard)

These are evolve-specific extensions to the Engine API that require special support in ev-reth. The concern is:

Does removing --ev-reth.enable disable support for these custom attributes?

My Analysis:

Looking at the other flag present in all configurations:

--engine.always-process-payload-attributes-on-canonical-head

This flag suggests ev-reth has custom Engine API behavior. The fact that:

1. No code changes were made to EngineClient.ExecuteTxs() (still sends custom attributes)
2. The flag was removed from ALL configurations (sequencer, full-node, test scripts)
3. CI is passing
4. The commit message simply says "remove unused flag"

Strongly suggests the flag is now obsolete - likely because the feature is now enabled by default in newer ev-reth versions, or was consolidated into the --engine.always-process-payload-attributes-on-canonical-head flag.

However, this critical context is missing from the PR description, making it impossible for reviewers to confidently approve without manual testing.

---

Detailed Review

1. Configuration Cleanup ✅

Files Modified:

• execution/evm/docker/docker-compose.yml (sequencer)
• execution/evm/docker/docker-compose-full-node.yml (full node)
• apps/evm/single/docker-compose.yml (single node)
• scripts/run-evm-nodes.go (multi-node test script)

Changes: Consistently removed --ev-reth.enable \ from all ev-reth node configurations.

Quality:

• ✅ Consistent across all configurations
• ✅ Maintains proper shell command formatting (trailing backslashes preserved)
• ✅ No accidental removal of other flags
• ✅ Formatting improvements in apps/evm/single/docker-compose.yml (indentation fix)

2. Dependency Updates

execution/evm/test/go.mod:

- github.com/celestiaorg/tastora v0.5.0
+ github.com/celestiaorg/tastora v0.7.3

test/e2e/go.mod:

- github.com/celestiaorg/tastora v0.7.1
+ github.com/celestiaorg/tastora v0.7.3

Analysis:

• ✅ Both test modules now use the same tastora version (v0.7.3) - good for consistency
• ✅ go.sum files properly updated
• ⚠️ Missing: No changelog/release notes reference explaining what changed in tastora v0.7.3

Note: @tac0turtle mentioned "we need a new version of testora" - this appears to be referring to tastora (likely a typo). This dependency bump is likely the actual reason for this PR, with the flag removal being a related cleanup.

3. Testing & CI

Observations:

• ✅ All CI checks passing (Buf, lint, codecov)
• ✅ No test modifications needed (confirms flag was unused/default)
• ⚠️ Recommendation: Run full E2E tests locally to verify block production works correctly without the flag

---

Security & Performance Review

Security ✅

• No security concerns introduced
• No changes to authentication, JWT handling, or API exposure
• Flag removal doesn't expose new attack surfaces

Performance ✅

• No performance impact expected
• All txpool and engine configuration parameters unchanged
• Memory and persistence thresholds remain at optimized values

---

Code Quality & Architecture

Strengths:

• ✅ Clean, focused change addressing single concern
• ✅ Consistent application across all deployment scenarios
• ✅ No dead code left behind
• ✅ Maintains idiomatic Go and Docker Compose style

Minor Issues:

• ⚠️ Indentation change in apps/evm/single/docker-compose.yml mixes with functional change (should ideally be separate commit for cleaner history)

---

Required Actions Before Merge

1. Update PR Description (High Priority)

The PR description is currently empty except for "## Overview". Please add:

## Overview

Removes the deprecated `--ev-reth.enable` flag from all ev-reth configurations. 
This flag is no longer needed as of ev-reth version X.Y.Z, where this functionality 
is now enabled by default (or consolidated into --engine.always-process-payload-attributes-on-canonical-head).

Also updates tastora dependency to v0.7.3 for [specific reason - link to changelog if available].

## Testing
- [ ] Verified block production works on local testnet
- [ ] Confirmed custom Engine API attributes (transactions, gasLimit) are still processed
- [ ] E2E tests passing

2. Verify E2E Tests (Critical)

Even though CI is passing, explicitly confirm:

• Block production works correctly
• engine_forkchoiceUpdatedV3 with custom attributes succeeds
• Both sequencer and full nodes sync properly

3. Document ev-reth Version Dependency (Nice to Have)

Consider adding a comment or documentation noting the minimum ev-reth version required:

# Requires ev-reth >= X.Y.Z (--ev-reth.enable is deprecated)
image: ghcr.io/evstack/ev-reth:latest

---

Recommendation

Conditional Approval: This PR is well-executed from a code quality perspective, but requires clarification in the PR description before final approval.

If the flag is truly obsolete (as the evidence suggests), this is a good cleanup.

If not, this would break block production in a non-obvious way that wouldn't be caught until runtime.

Given that @tac0turtle is the author and likely has context that confirms this is safe, I recommend:

1. Update the PR description with the context
2. Confirm E2E tests pass (they likely already did during development)
3. Merge

---

Additional Notes

The tastora version bump from v0.5.0 → v0.7.3 is a minor version jump that could potentially include breaking changes or important fixes. Consider reviewing the tastora changelog to ensure no unexpected behavior changes.

---

Files Reviewed: 8/8
Critical Issues: 0
Warnings: 2 (documentation, testing verification)
CI Status: ✅ All checks passing

---

[github-actions]

The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	⏩ skipped	✅ passed	✅ passed	Oct 17, 2025, 11:48 AM

[gemini-code-assist]

Code Review

This pull request removes the --ev-reth.enable flag from the docker-compose.yml file for the ev-reth service. While the change itself is a single line deletion, it poses a significant risk. My review has identified a potential critical issue: the EngineClient implementation in this repository relies on custom, non-standard Engine API behavior that this flag most likely enables in the ev-reth execution client. Removing it without corresponding client-side changes could break the communication between the services and halt block production.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.42%. Comparing base (de40783) to head (b1c4eba).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2765   +/-   ##
=======================================
  Coverage   61.42%   61.42%           
=======================================
  Files          81       81           
  Lines        8622     8622           
=======================================
  Hits         5296     5296           
  Misses       2828     2828           
  Partials      498      498           

Flag	Coverage Δ
combined	61.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tac0turtle]

we need a new version of testora