Skip to content

refactor: omit unnecessary reassignment #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tac0turtle merged 1 commit into from
Aug 20, 2025
Merged

refactor: omit unnecessary reassignment #2584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions block/namespace_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ func TestProcessNextDAHeaderAndData_MixedResults(t *testing.T) {
}

for _, tt := range tests {
tt := tt
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Removing the tt := tt shadowing is only safe if the project's Go version is 1.22 or higher. This change relies on the new loop variable semantics introduced in Go 1.22. If the project is compiled with an older Go version, this will introduce a race condition in these parallel tests, causing them to behave incorrectly and fail unpredictably.

Recommendation:
To prevent this critical issue, the go.mod file must be updated to go 1.22 or newer as part of this pull request. If updating the Go version is not possible, this change should be reverted.

t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -234,7 +233,6 @@ func TestNamespaceMigration_Completion(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -426,7 +424,6 @@ func TestLegacyNamespaceDetection(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down
Loading