Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Chore: Add skystrife as a submodule #825

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

roninjin10
Copy link
Collaborator

@roninjin10 roninjin10 commented Jan 16, 2024

Description

Add skystrife to lib/skystrife. Tevm will be used in skystrife as a POC for MUD

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

Summary by CodeRabbit

  • New Features
    • Integrated a new submodule to enhance project capabilities.

Copy link

changeset-bot bot commented Jan 16, 2024

⚠️ No Changeset found

Latest commit: fd14cd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evmts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 7:01pm

Copy link
Contributor

coderabbitai bot commented Jan 16, 2024

Walkthrough

The repository has been updated to include a new submodule. This submodule, identified as "skystrife," has been set up with a specific commit from its development history, ensuring that the main project is linked to a particular snapshot of the "skystrife" codebase.

Changes

File Change Summary
.gitmodules Added new submodule "lib/skystrife"
lib/skystrife Subproject commit set to 904eb5...e80f

🐇✨
In the warren of code, a new burrow's found,
A module of sky, where stars abound.
Commit hash planted, roots grow deep,
CodeRabbit's joy, in bytes, does leap.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@roninjin10
Copy link
Collaborator Author

roninjin10 commented Jan 16, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f786531 and fd14cd4.
Files selected for processing (2)
  • .gitmodules (1 hunks)
  • lib/skystrife (1 hunks)
Files skipped from review due to trivial changes (1)
  • lib/skystrife
Additional comments: 1
.gitmodules (1)
  • 10-12: The submodule declaration for "lib/skystrife" is correctly added and follows the existing format.

@roninjin10 roninjin10 mentioned this pull request Jan 16, 2024
1 task
@roninjin10 roninjin10 merged commit a8d42f4 into main Jan 17, 2024
19 checks passed
@roninjin10 roninjin10 deleted the 01-16-chore_Add_skystrife_as_a_submodule branch January 17, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant