Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Chore: Switch package manager back to pnpm from bun #676

Merged

Conversation

roninjin10
Copy link
Collaborator

Description

Switching package manager back to pnpm for following reasons:

  1. The feature pnpm has of forcing packages to be extra explicit with dependencies. With bun there is a risk of packages depending on hoisting and failing to work once published to npm without the hoisted packages. It also makes unexpected changes between package dependencies possible.
  2. Changesets don't support bun very well it seems
  3. Small bugs with bun slow down development. For example, moving a workspace package often requires a rm -rf bun.lockb to fix

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evmts-docs ❌ Failed (Inspect) Nov 17, 2023 10:47pm

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: 08d41e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@evmts/resolutions Patch
@evmts/ts-plugin Patch
@evmts/experimental-solc Patch
@evmts/ethers Patch
@evmts/unplugin Patch
@evmts/schemas Patch
@evmts/esbuild-plugin Patch
@evmts/runtime Patch
@evmts/webpack-plugin Patch
@evmts/effect Patch
@evmts/config Patch
@evmts/rollup-plugin Patch
@evmts/rspack-plugin Patch
@evmts/core Patch
@evmts/solc Patch
@evmts/vite-plugin Patch
@evmts/bun-plugin Patch
@evmts/bundler Patch
@evmts/vm Patch
@evmts/blockexplorer Patch
@evmts/base Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@roninjin10
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@roninjin10 roninjin10 force-pushed the 11-17-chore_Switch_package_manager_back_to_pnpm_from_bun branch from b958aee to d9bee05 Compare November 17, 2023 22:38
@roninjin10 roninjin10 force-pushed the 11-17-chore_Switch_package_manager_back_to_pnpm_from_bun branch from d9bee05 to 08d41e7 Compare November 17, 2023 22:42
Copy link
Contributor

Coverage Report for @evmts/core (./packages/core)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 186 / 186
🟢 Statements 100% / 100% 186 / 186
🟢 Functions 100% / 100% 7 / 7
🟢 Branches 100% / 100% 19 / 19
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/ethers (./extensions/ethers)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 20 / 20
🟢 Statements 100% / 100% 20 / 20
🟢 Functions 100% / 100% 0 / 0
🟢 Branches 100% / 100% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/base (./bundler/base)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 285 / 285
🟢 Statements 100% / 100% 285 / 285
🟢 Functions 100% / 100% 13 / 13
🟢 Branches 100% / 100% 57 / 57
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/bun-plugin (./bundler/bun)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 120 / 120
🟢 Statements 100% / 100% 120 / 120
🟢 Functions 100% / 100% 4 / 4
🟢 Branches 100% / 100% 15 / 15
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/esbuild-plugin (./bundler/esbuild)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 3 / 3
🟢 Statements 100% / 100% 3 / 3
🟢 Functions 100% / 100% 0 / 0
🟢 Branches 100% / 100% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/ts-plugin (./bundler/ts-plugin)

Status Category Percentage Covered / Total
🟢 Lines 90.56% / 90% 624 / 689
🟢 Statements 90.56% / 90% 624 / 689
🟢 Functions 96.96% / 96% 32 / 33
🟢 Branches 86.08% / 86% 99 / 115
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/config (./bundler/config)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 704 / 704
🟢 Statements 100% / 100% 704 / 704
🟢 Functions 100% / 100% 33 / 33
🟢 Branches 98.91% / 98% 91 / 92
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/schemas (./packages/schemas)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 4478 / 4478
🟢 Statements 100% / 100% 4478 / 4478
🟢 Functions 100% / 100% 255 / 255
🟢 Branches 100% / 100% 309 / 309
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/blockexplorer (./packages/blockexplorer)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 250 / 250
🟢 Statements 100% / 100% 250 / 250
🟢 Functions 100% / 100% 10 / 10
🟢 Branches 100% / 100% 19 / 19
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/runtime (./bundler/runtime)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 130 / 130
🟢 Statements 100% / 100% 130 / 130
🟢 Functions 100% / 100% 3 / 3
🟢 Branches 95.23% / 95% 20 / 21
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/solc (./bundler/solc)

Status Category Percentage Covered / Total
🟢 Lines 92.77% / 92% 488 / 526
🟢 Statements 92.77% / 92% 488 / 526
🟢 Functions 100% / 100% 14 / 14
🟢 Branches 72.72% / 72% 48 / 66
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/unplugin (./bundler/unplugin)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 113 / 113
🟢 Statements 100% / 100% 113 / 113
🟢 Functions 100% / 100% 4 / 4
🟢 Branches 100% / 100% 20 / 20
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/resolutions (./bundler/resolutions)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 582 / 582
🟢 Statements 100% / 100% 582 / 582
🟢 Functions 100% / 100% 35 / 35
🟢 Branches 100% / 100% 85 / 85
File CoverageNo changed files found.
Generated in workflow #1344

Copy link
Contributor

Coverage Report for @evmts/effect (./packages/effect)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 243 / 243
🟢 Statements 100% / 100% 243 / 243
🟢 Functions 100% / 100% 22 / 22
🟢 Branches 100% / 100% 34 / 34
File CoverageNo changed files found.
Generated in workflow #1344

@roninjin10 roninjin10 merged commit 93cab84 into main Nov 17, 2023
9 of 10 checks passed
@roninjin10 roninjin10 deleted the 11-17-chore_Switch_package_manager_back_to_pnpm_from_bun branch November 17, 2023 22:47
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
roninjin10 pushed a commit that referenced this pull request Nov 17, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

## @evmts/[email protected]

### Patch Changes

- Updated dependencies
\[[`93cab845`](93cab84)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

## @evmts/[email protected]

### Patch Changes

- [#676](#676)
[`93cab845`](93cab84)
Thanks [@roninjin10](https://github.com/roninjin10)! - Switched package
manager to pnpm from bun

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant