🐛 Fix: eth_estimateGas

[roninjin10]

Description

1. Typescript type for estimateGas json request wrong
2. State overrides and block tag handled wrong

Testing

Explain the quality checks that have been done on the code changes

Additional Information

• I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

• New Features

  • Enhanced gas estimation accuracy for Ethereum transactions by fixing a bug related to the eth_estimateGas method.
  • Introduced optional parameters for gas estimation requests, allowing for greater flexibility in specifying block tags and state overrides.

• Bug Fixes

  • Resolved issues with handling block tags and state overrides in gas estimation.

• Tests

  • Added new test cases to improve coverage for gas estimation functionality, including scenarios for handling block tags and specific contract interactions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
tevm-monorepo-tevm	⬜️ Ignored (Inspect)		Sep 13, 2024 4:45pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 0802387

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@tevm/procedures	Patch
@tevm/ethers	Patch
@tevm/viem	Patch
@tevm/decorators	Patch
@tevm/memory-client	Patch
@tevm/server	Patch
tevm	Patch
@tevm/cli	Patch
@tevm/http-client	Patch
tevm-run	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[roninjin10]

• 🐛 Fix: eth_estimateGas #1430 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite

[coderabbitai]

Walkthrough

This update introduces a patch for the @tevm/procedures package to fix a bug in the eth_estimateGas JSON-RPC method, improving its handling of block tags and state overrides. Changes include updates to the EthEstimateGasJsonRpcRequest type definition, restructuring parameters in the gas estimation request, and adding new test cases to enhance coverage for gas estimation functionality.

Changes

Files	Change Summary
.changeset/forty-mugs-exist.md	Introduced a patch for @tevm/procedures to fix eth_estimateGas handling of block tags and state overrides.
packages/procedures/src/eth/EthJsonRpcRequest.ts	Modified EthEstimateGasJsonRpcRequest to include optional parameters: tag, stateOverrideSet, blockOverrideSet.
packages/procedures/src/eth/ethEstimateGasProcedure.js	Restructured parameters for gas estimation requests to enhance flexibility.
packages/memory-client/src/test/viem/estimateGas.spec.ts	Added a test case for gas estimation involving a contract call to set.
packages/procedures/src/eth/ethEstimateGasProcedure.spec.ts	Added a test case to validate handling of block tags in gas estimation requests.

Possibly related PRs

• ✨ Feat: Add deployHandler #1058: Changes in createTransaction involve gas limit calculations relevant to gas estimation improvements.
• ✅ Test: Add a bunch of viem api tests #1109: This PR adds tests for the viem API, which may include tests related to gas estimation, aligning with the enhancements made in the main PR.
• ✨ Feat: Add events to tevm #1154: The introduction of event JSON-RPC support may relate to the gas estimation process, as events can impact transaction costs and gas usage.
• 🐛 Fix: Procedures imports #1202: Updates to procedure imports, including EthEstimateGasJsonRpcRequest, directly relate to the changes made in the main PR regarding gas estimation.
• 🧪 Test: Add more procedures tests #1247: Adding more tests for procedures may include tests for gas estimation functionalities, which are central to the main PR's objectives.

🐰 In the meadow, where bunnies play,
Gas estimates now lead the way!
With block tags and states in view,
Transactions flow, swift and true.
Hopping high, we cheer with glee,
For gas fixes, oh what a spree! 🌼

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc8e69c and 0802387.

Files ignored due to path filters (1)

• packages/procedures/src/eth/__snapshots__/ethEstimateGasProcedure.spec.ts.snap is excluded by !**/*.snap

Files selected for processing (5)

• .changeset/forty-mugs-exist.md (1 hunks)
• packages/memory-client/src/test/viem/estimateGas.spec.ts (1 hunks)
• packages/procedures/src/eth/EthJsonRpcRequest.ts (1 hunks)
• packages/procedures/src/eth/ethEstimateGasProcedure.js (1 hunks)
• packages/procedures/src/eth/ethEstimateGasProcedure.spec.ts (2 hunks)

Files skipped from review as they are similar to previous changes (5)

• .changeset/forty-mugs-exist.md
• packages/memory-client/src/test/viem/estimateGas.spec.ts
• packages/procedures/src/eth/EthJsonRpcRequest.ts
• packages/procedures/src/eth/ethEstimateGasProcedure.js
• packages/procedures/src/eth/ethEstimateGasProcedure.spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.