🐛 fix: eth get_logs not handling hex numbers

[roninjin10]

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

• I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

• Bug Fixes

  • Resolved an issue with the eth_getLogs function for better handling of hexadecimal number formats.

• New Features

  • Introduced a new utility for parsing block parameters, enhancing flexibility in handling blockchain references.
  • Added a comprehensive test suite for the new block parameter parsing functionality.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
tevm-monorepo-tevm	⬜️ Ignored (Inspect)		Sep 12, 2024 11:30pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 0a65772

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@tevm/actions	Patch
@tevm/cli	Patch
@tevm/viem	Patch
@tevm/decorators	Patch
@tevm/memory-client	Patch
@tevm/procedures	Patch
@tevm/server	Patch
tevm	Patch
@tevm/ethers	Patch
@tevm/http-client	Patch
tevm-run	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a patch for the @tevm/actions package, focusing on fixing a bug in the eth_getLogs function related to number formatting. The changes include the removal of a block parameter parsing function from ethGetLogsHandler.js, which is now imported from a utility file, enhancing code organization. A new parseBlockParam function has been added to handle block parameters dynamically, along with a comprehensive test suite to ensure its reliability.

Changes

File(s)	Change Summary
.changeset/empty-plums-pretend.md	AI-generated summary of changes.
packages/actions/src/eth/ethGetLogsHandler.js	Fixed bug in eth_getLogs, removed parseBlockParam, added import from ./utils/parseBlockParam.js.
packages/actions/src/eth/utils/parseBlockParam.js	Added parseBlockParam function to handle block parameters.
packages/actions/src/eth/utils/parseBlockParam.spec.ts	Added tests for parseBlockParam function.

Assessment against linked issues

Objective	Addressed	Explanation
Fix bug in eth_getLogs function (undefined)	✅
Improve block parameter handling (undefined)	✅

Possibly related issues

• None

Possibly related PRs

• ✨ Feat: Implement eth_getLogs #1083: This PR implements the eth_getLogs feature, which is directly related to the bug fix in the eth_getLogs function in the main PR.
• ✨ Feat: Add events to tevm #1154: This PR introduces support for event JSON-RPC in the tevm project, which may relate to the logging functionality enhanced in the main PR.

🐰 In the land of code where rabbits play,
A bug was fixed without delay.
Logs now dance in hex so bright,
With parsing done just right!
So hop along, let’s test away,
For every log, a joyful day! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.