Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Change contract import of generated file to import type {Contract} #1382

Conversation

roninjin10
Copy link
Collaborator

@roninjin10 roninjin10 commented Aug 14, 2024

Description

closes #1343

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
tevm-monorepo-tevm ⬜️ Ignored (Inspect) Aug 15, 2024 4:06am

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: c183776

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@tevm/runtime Patch
@tevm/base-bundler Patch
@tevm/bun-plugin Patch
@tevm/unplugin Patch
@tevm/ts-plugin Patch
tevm Patch
tevm-run Patch
@tevm/precompiles Patch
@tevm/esbuild-plugin Patch
@tevm/rollup-plugin Patch
@tevm/rspack-plugin Patch
@tevm/vite-plugin Patch
@tevm/webpack-plugin Patch
@tevm/test-utils Patch
@tevm/ethers Patch
@tevm/viem Patch
@tevm/actions Patch
@tevm/http-client Patch
@tevm/memory-client Patch
@tevm/node Patch
@tevm/procedures Patch
@tevm/server Patch
@tevm/state Patch
@tevm/decorators Patch
@tevm/evm Patch
@tevm/sync-storage-persister Patch
@tevm/txpool Patch
@tevm/vm Patch
@tevm/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 14, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator Author

roninjin10 commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite Graphite

@roninjin10 roninjin10 mentioned this pull request Aug 14, 2024
1 task
@roninjin10 roninjin10 marked this pull request as ready for review August 14, 2024 19:47
@roninjin10 roninjin10 force-pushed the 08-14-_memo_feat_add_natspec_comments_to_contract_imports branch from fcee84a to 56e1553 Compare August 15, 2024 03:43
@roninjin10 roninjin10 force-pushed the 08-14-_bug_fix_change_contract_import_of_generated_file_to_import_type_contract_ branch from 4b6c7b7 to 4ccea49 Compare August 15, 2024 03:43
@roninjin10 roninjin10 force-pushed the 08-14-_memo_feat_add_natspec_comments_to_contract_imports branch from 56e1553 to f06ff2b Compare August 15, 2024 04:01
@roninjin10 roninjin10 force-pushed the 08-14-_bug_fix_change_contract_import_of_generated_file_to_import_type_contract_ branch from 4ccea49 to 4f86c55 Compare August 15, 2024 04:01
@roninjin10 roninjin10 force-pushed the 08-14-_memo_feat_add_natspec_comments_to_contract_imports branch from f06ff2b to 38a30bd Compare August 15, 2024 04:06
@roninjin10 roninjin10 force-pushed the 08-14-_bug_fix_change_contract_import_of_generated_file_to_import_type_contract_ branch from 4f86c55 to c183776 Compare August 15, 2024 04:06
Base automatically changed from 08-14-_memo_feat_add_natspec_comments_to_contract_imports to main August 15, 2024 04:23
@roninjin10 roninjin10 merged commit 7eebe33 into main Aug 15, 2024
9 checks passed
@roninjin10 roninjin10 deleted the 08-14-_bug_fix_change_contract_import_of_generated_file_to_import_type_contract_ branch August 15, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change compiler d.ts to generate type only import
1 participant