fix(tests): make integration tests more consistent

[ramacarlucho]

Closes: #XXX

Description

Integration tests are not stable enough.
Instead of waiting for tx receipts, attempt to resend tx a couple of times.

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[fedekunze]

@ramacarlucho is this a duplicate from #1488? Can you explain the different approaches

[ramacarlucho]

@ramacarlucho is this a duplicate from #1488? Can you explain the different approaches

@fedekunze most of the tests are failing because we are waiting for a tx receipt on a failed send tx (even on that pr). So this is an attempt to solve that issue.

i think both prs are trying to solve the same issue.

I still have some inconsistency in some tests, that im trying to figure out

[ramacarlucho]

@yihuang do you know what is causing this response in the following bit of code?

ethermint/tests/integration_tests/test_grpc_only.py

Lines 53 to 66 in 20094cd

	w3 = custom_ethermint.w3
	contract, _ = deploy_contract(w3, CONTRACTS["TestChainID"])
	assert 9000 == contract.caller.currentChainID()
	msg = {
	"to": contract.address,
	"data": contract.encodeABI(fn_name="currentChainID"),
	}
	api_port = ports.api_port(custom_ethermint.base_port(2))
	# in normal mode, grpc query works even if we don't pass chain_id explicitly
	rsp = grpc_eth_call(api_port, msg)
	print(rsp)
	assert "code" not in rsp, str(rsp)
	assert 9000 == int.from_bytes(base64.b64decode(rsp["ret"].encode()), "big")

Contract deployment should not be faling, so i dont understand the empty response.

[yihuang]

@yihuang do you know what is causing this response in the following bit of code?

ethermint/tests/integration_tests/test_grpc_only.py

Lines 53 to 66 in 20094cd

	w3 = custom_ethermint.w3
	contract, _ = deploy_contract(w3, CONTRACTS["TestChainID"])
	assert 9000 == contract.caller.currentChainID()
	msg = {
	"to": contract.address,
	"data": contract.encodeABI(fn_name="currentChainID"),
	}
	api_port = ports.api_port(custom_ethermint.base_port(2))
	# in normal mode, grpc query works even if we don't pass chain_id explicitly
	rsp = grpc_eth_call(api_port, msg)
	print(rsp)
	assert "code" not in rsp, str(rsp)
	assert 9000 == int.from_bytes(base64.b64decode(rsp["ret"].encode()), "big")

Contract deployment should not be faling, so i dont understand the empty response.

and the gas_used is weird.

[mmsqe]

Contract deployment should not be faling, so i dont understand the empty response.

Seems retry could help to alleviate the gap.

0 {'hash': '0x0000000000000000000000000000000000000000000000000000000000000000', 'logs': [], 'ret': None, 'vm_error': '', 'gas_used': '4611686018427387903'}
[1856](https://github.com/evmos/ethermint/actions/runs/3560964594/jobs/5981443537#step:6:1857)
1 {'hash': '0x0000000000000000000000000000000000000000000000000000000000000000', 'logs': [], 'ret': 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIyg=', 'vm_error': '', 'gas_used': '4611686018427387903'}

[adisaran64]

Left a suggestion. The test_cosmovisor_upgrade is still failing with a timeout error, for some reason it looks like blocks aren't being produced past a certain point?

[fedekunze]

@ramacarlucho @adisaran64 can you fix the conflicts?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.