Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Star and Arrow from Semigroups to Semigroupoids #127

Merged
merged 1 commit into from
May 21, 2017
Merged

Move Star and Arrow from Semigroups to Semigroupoids #127

merged 1 commit into from
May 21, 2017

Conversation

evilsoft
Copy link
Owner

Mistakes were made...

image

So now that this fantasyland PR has been merged in, it provides exactly what we need to address this issue.

This PR does the following:

  • Replaces concat with compose on both Star and Arrow
  • Replaces empty with id on Arrow (for some sweet Category action)
  • Adds composeS and pipeS helper functions for composing Semigroupoids
  • Adds the isCategory and isSemigroupoid predicate functions.

@coveralls
Copy link

coveralls commented May 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6f6a86e on compose-arrows into c65b930 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e580c50 on compose-arrows into c65b930 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e580c50 on compose-arrows into c65b930 on master.

@coveralls
Copy link

coveralls commented May 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e580c50 on compose-arrows into c65b930 on master.

@coveralls
Copy link

coveralls commented May 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c6dcdf2 on compose-arrows into c65b930 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c6dcdf2 on compose-arrows into c65b930 on master.

@evilsoft
Copy link
Owner Author

image

@evilsoft evilsoft merged commit 0fe21a5 into master May 21, 2017
@evilsoft evilsoft deleted the compose-arrows branch May 21, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evilsoft @coveralls