Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concat and empty from Arrow and Star #103

Closed
6 of 8 tasks
evilsoft opened this issue Mar 6, 2017 · 2 comments
Closed
6 of 8 tasks

Remove concat and empty from Arrow and Star #103

evilsoft opened this issue Mar 6, 2017 · 2 comments

Comments

@evilsoft
Copy link
Owner

evilsoft commented Mar 6, 2017 •
edited
Loading

Does not make sense to use concat for composition.

This was a huge mistake on so many levels. A few things need to be done to make these able to be composed.

  • Remove concat and empty from Arrow
  • Remove concat from Star
  • Add a compose function to Star
  • Add a compose function to Arrow
  • Update pipe to compose Arrows and Stars
  • Update compose to compose Arrows and Stars
  • Add a pipeS helper to compose Arrows and Stars (Semigroupoids)
  • Add a composeS helper to compose Arrows and Stars (Semigroupoids)
@evilsoft
Copy link
Owner Author

Submitted PR#127 to fully address this here issue.
YAY!!

@evilsoft
Copy link
Owner Author

PR#127 has been merged and will go out on the next release. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evilsoft