find eigen using config mode #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
briansoe66
commented
Sep 12, 2023
briansoe66
commented
- target_link_libraries eigen target, instead of including absolute path to eigen headers.
- find_dependency eigen in ifopt-config.cmake, because eigen is a public dependency
- remove FindEigen3.cmake and FindGTest.cmake modules. Both libraries support finding package via cmake config mode
- this change makes ifopt install files transferable to different filesystem location, because the absolute path to eigen headers is no longer hard-coded in the installed target files
…ath to eigen headers. * find_dependency eigen in ifopt-config.cmake, because eigen is a public dependency * remove FindEigen3.cmake and FindGTest.cmake modules. Both libraries support finding package via cmake config mode * this change makes ifopt install files transferable to different filesystem location, because the absolute path to eigen headers is no longer hard-coded in the installed target files
Levi-Armstrong
requested changes
Sep 12, 2023
|
@awinkler I just wanted to check to make sure this not going to impact other packages; you see any issue with merging this? |
|
Looks good to me!👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.