chore: Support multiple supervisors: Decouple challengers from networks [4/N]#243
chore: Support multiple supervisors: Decouple challengers from networks [4/N]#243janjakubnanista merged 2 commits intomainfrom
Conversation
656dcc3 to
45affae
Compare
8770dec to
3e0e845
Compare
Yeah that seems fine to me. I guess fundamentally what we would like to write is some sort of predicate to select the right items in the overall topology, but yaml being yaml it's gonna look a little bit uglier than that :) |
3e0e845 to
3a562e9
Compare
@sigma you could use tags like kubernetes for this no? Make sure all the chains you want challenger to run against are tagged with a |
|
@janjakubnanista just looked at the new config in the README, its a bit ambiguous how to set this off to turn off all challengers. Aka what's the default behavior if I don't add a |
See ethpandaops/optimism-package#243 for when/why this refactor happened
See ethpandaops/optimism-package#243 for when/why this refactor happened

Description
The challenger instances are decoupled from L2 networks and their configuration is moving to the top-level configuration.
Notes
There are several larger motions in this PR aimed at laying down the groundwork for further improvements:
dict, then reformatting it to astructhas been removed. As it is, it adds no value and only creates room for errorchallengers.default_paramsobject. Instead, YAML anchors can be utilised to share pieces of configuration. This removes the need for extra parsing logic and keeps things as lean as possibleservice_nameproperty. This will become important when it comes to resolving circular dependencies later on, as URLs will be possible to construct without having an instance ofServicemkdir &&combined withsh -centrypoint has been replaced (only forop-challenger) with a persistent directory.Questions
@sigma there will be more objects where something points to a list of networks. I named the field
participantsso that later on we might expand it to cover both networks and interop sets (with a heterogeneous list of some sort, TBD). That okay? I want to avoid confusion withparticipantsinchainsthat signify nodes rather than networks.Related to ethereum-optimism/optimism#15611