Conversation
samlaf
left a comment
samlaf
left a comment
There was a problem hiding this comment.
Approved. kurtosis CI is failing because of ethpandaops/optimism-package#243. Will fix in another PR
bin/host/src/cfg.rs
Outdated
| // uncomment if running preloaded eigenda client | ||
| //let client_task = task::spawn( | ||
| // hokulea_witgen_client::witgen_client::run_preloaded_eigenda_client( | ||
| // OracleReader::new(preimage.client.clone()), | ||
| // HintWriter::new(hint.client.clone()), | ||
| // FpvmOpEvmFactory::new( | ||
| // HintWriter::new(hint.client), | ||
| // OracleReader::new(preimage.client), | ||
| // ), | ||
| // ), | ||
| //); |
There was a problem hiding this comment.
when do you uncomment this? Could we put this behind an if statement, or a compile flag instead?
There was a problem hiding this comment.
I am thinking we should have a binary or test to just run preloaded eigenda client. Not sure how to do it with a test
| P: PreimageOracleClient + Send + Sync + Debug + Clone, | ||
| H: HintWriterClient + Send + Sync + Debug + Clone, | ||
| Evm: EvmFactory<Spec = OpSpecId> + Send + Sync + Debug + Clone + 'static, | ||
| <Evm as EvmFactory>::Tx: FromTxWithEncoded<OpTxEnvelope> + FromRecoveredTx<OpTxEnvelope>, |
There was a problem hiding this comment.
is this associated type bound that we always add really needed? We don't even seem to be calling evmFactory ourselves. Guessing its used somewhere in some internal kona library, but I don't get it (not super familiar with how these bounds are used)
There was a problem hiding this comment.
I just make it consistent to kona library. Will think more about it,
Maybe relate to this? op-rs/kona#1400
samlaf
left a comment
samlaf
left a comment
There was a problem hiding this comment.
LGTM. Prob good to rebase on top of my kurtosis fix PR to make CI pass, but not strictly necessary.
2 participants
This Pr bump kona deps to 1.0.0
Kona adds EvmFactory and op-revm to abstract execution and precompile, see op-rs/kona#1543