Skip to content

fix: Vc count logic #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barnabasbusa merged 3 commits into from
May 28, 2024
Merged

fix: Vc count logic #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8842110
fix divide by zero
0xTylerHolmes May 26, 2024
061dbec
fix index out of bounds issues when vc_count = 0
0xTylerHolmes May 26, 2024
fcaf38a
fix lint
barnabasbusa May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cl/cl_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def launch(

cl_service_name = "cl-{0}-{1}-{2}".format(index_str, cl_type, el_type)
new_cl_node_validator_keystores = None
if participant.validator_count != 0:
if participant.validator_count != 0 and participant.vc_count != 0:
new_cl_node_validator_keystores = preregistered_validator_keys_for_nodes[
index
]
Expand Down
3 changes: 2 additions & 1 deletion src/package_io/input_parser.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,8 @@ def parse_network_params(plan, input_args):

# If the num validator keys per node is not divisible by vc_count of a participant, fail
if (
result["network_params"]["num_validator_keys_per_node"]
participant["vc_count"] > 0
and result["network_params"]["num_validator_keys_per_node"]
% participant["vc_count"]
!= 0
):
Expand Down
5 changes: 4 additions & 1 deletion src/participant_network.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,10 @@ def launch_participant_network(

el_context = all_el_contexts[index]
cl_context = all_cl_contexts[index]
vc_context = all_vc_contexts[index]
if participant.vc_count != 0:
vc_context = all_vc_contexts[index]
else:
vc_context = None

if participant.snooper_enabled:
snooper_engine_context = all_snooper_engine_contexts[index]
Expand Down