fix: Vc count logic#640
Merged
barnabasbusa merged 3 commits intoethpandaops:bbusa/vc_countfrom May 28, 2024
Merged
Conversation
Collaborator
|
can you please run |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a few index out of bounds and divide by zero issues. I fixed those with what I expect is the right method. One thing I would like you to check is my change on the participant_network.star
I added a check on the
vc_contextassignment for the case wherevc_count == 0. We would get an index out of bounds panic so I just set it toNone. I'm unsure if there are downstream consequences but everything appears to be working on my end with that.