Skip to content

baseFee to baseFeePerGas#881

Merged
winsvega merged 1 commit intodevelopfrom
basefeeRename
Jun 11, 2021
Merged

baseFee to baseFeePerGas#881
winsvega merged 1 commit intodevelopfrom
basefeeRename

Conversation

@winsvega
Copy link
Copy Markdown

No description provided.

@winsvega winsvega merged commit bd20f98 into develop Jun 11, 2021
@winsvega winsvega deleted the basefeeRename branch June 11, 2021 11:16
@holiman
Copy link
Copy Markdown
Contributor

holiman commented Jun 14, 2021

Why did you change that? The term is baseFee ? It's in the EIP itself and, afaik, every client implementation.

@holgerd77
Copy link
Copy Markdown
Contributor

We have actually also named this baseFeePerGas following changes on the RPC spec like ethereum/execution-specs#192 and in the spec it is also named base_fee_per_gas, see https://eips.ethereum.org/EIPS/eip-1559.

Do I miss something here? 🤔

@holiman
Copy link
Copy Markdown
Contributor

holiman commented Jun 14, 2021

Do I miss something here? thinking

Nope, apparently it was me who missed something. Apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants