Skip to content

core: make genesis parse baseFee correctly#23013

Merged
karalabe merged 1 commit intoethereum:masterfrom
holiman:genesis_fix
Jun 14, 2021
Merged

core: make genesis parse baseFee correctly#23013
karalabe merged 1 commit intoethereum:masterfrom
holiman:genesis_fix

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Jun 8, 2021

This is needed to parse genesis basefee with hex encoding which is used for consensus-tests in hive

Copy link
Copy Markdown
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.4 milestone Jun 8, 2021
@karalabe karalabe merged commit ccf53da into ethereum:master Jun 14, 2021
@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Jun 14, 2021

Thanks for the merge! It just stopped working, though, because test tests were updated to call the field "baseFeePerGas", for some reason. ethereum/tests#881

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Jun 14, 2021

We need to change this again, to read baseFeePerGas instead of baseFee. It's actually the original term from the the EIP (https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants