Skip to content

Comments

clients/go-ethereum: set syncmode=full by default#586

Merged
fjl merged 1 commit intoethereum:masterfrom
MariusVanDerWijden:fix-geth
Jul 4, 2022
Merged

clients/go-ethereum: set syncmode=full by default#586
fjl merged 1 commit intoethereum:masterfrom
MariusVanDerWijden:fix-geth

Conversation

@MariusVanDerWijden
Copy link
Member

We changed something in geth that makes a lot of tests fail in snap sync mode.
Basically you can not import blocks one by one in snap sync mode, the snap sync has to finish before importing blocks one by one, otherwise we might overwrite data that is already in the database.
The tests depend on this one-by-one importing though, which is only available to a full synced node in geth. This changes the default sync mode to full.

@fjl fjl merged commit 60d48c5 into ethereum:master Jul 4, 2022
@holiman
Copy link
Contributor

holiman commented Aug 31, 2022

IIUC, this PR made it so that our sync-test now uses a full-sync for testing. So we now have no test that actually tests whether geth can default-sync (snap) from geth.

racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
This PR introduces a new mev boost/mev relay created by @ralexstokes.
It can be triggered by:
`mev_type: mev-rs`

It gets rid of the previously used `full` flag and flashbots will work
under the `mev_type: flashbots` following this PR.
racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](ethpandaops/ethereum-package@2.2.0...3.0.0)
(2024-05-06)


### ⚠ BREAKING CHANGES

* add mev-rs relay/builder/boost
([ethereum#586](ethpandaops/ethereum-package#586))
* upcoming file path change in kurtosis upstream
([ethereum#582](ethpandaops/ethereum-package#582))

### Features

* add apache file server
([ethereum#581](ethpandaops/ethereum-package#581))
([205256a](ethpandaops/ethereum-package@205256a))
* add enr/enode to apache
([ethereum#589](ethpandaops/ethereum-package#589))
([b789e17](ethpandaops/ethereum-package@b789e17))
* add execution client urls to dora config
([ethereum#588](ethpandaops/ethereum-package#588))
([2a20d5a](ethpandaops/ethereum-package@2a20d5a))
* add mev-rs relay/builder/boost
([ethereum#586](ethpandaops/ethereum-package#586))
([525a8fb](ethpandaops/ethereum-package@525a8fb))
* Add peerdas support
([ethereum#591](ethpandaops/ethereum-package#591))
([14296ca](ethpandaops/ethereum-package@14296ca))
* add snooper urls to assertoor config
([ethereum#571](ethpandaops/ethereum-package#571))
([87f383f](ethpandaops/ethereum-package@87f383f))
* allow setting exit ip address
([ethereum#584](ethpandaops/ethereum-package#584))
([aabc942](ethpandaops/ethereum-package@aabc942))


### Bug Fixes

* non-existent field access on error message
([ethereum#577](ethpandaops/ethereum-package#577))
([8515d27](ethpandaops/ethereum-package@8515d27))
* participant redefining global flag
([ethereum#573](ethpandaops/ethereum-package#573))
([9139f4b](ethpandaops/ethereum-package@9139f4b))
* path for shadowforks post kt update
([ethereum#585](ethpandaops/ethereum-package#585))
([e0622a7](ethpandaops/ethereum-package@e0622a7))
* remove erigon's --chain parameter
([ethereum#575](ethpandaops/ethereum-package#575))
([02b9c50](ethpandaops/ethereum-package@02b9c50))
* upcoming file path change in kurtosis upstream
([ethereum#582](ethpandaops/ethereum-package#582))
([8d7c4f9](ethpandaops/ethereum-package@8d7c4f9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants